Closed Bug 1411476 Opened 7 years ago Closed 7 years ago

Add logs to debug test_bug495145.html timeout

Categories

(Core :: Audio/Video: Playback, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

Assignee: nobody → jwwang
Blocks: 1404373
Priority: -- → P5
Attachment #8921772 - Flags: review?(gsquelart)
Attachment #8921773 - Flags: review?(gsquelart)
Attachment #8921774 - Flags: review?(gsquelart)
Attachment #8921775 - Flags: review?(gsquelart)
Attachment #8921776 - Flags: review?(gsquelart)
Comment on attachment 8921772 [details]
Bug 1411476. P1 - add a space before mAudioCompleted and run clang-format.

https://reviewboard.mozilla.org/r/192798/#review198066
Attachment #8921772 - Flags: review?(gsquelart) → review+
Comment on attachment 8921773 [details]
Bug 1411476. P2 - show duration in debug logs.

https://reviewboard.mozilla.org/r/192800/#review198072
Attachment #8921773 - Flags: review?(gsquelart) → review+
Comment on attachment 8921774 [details]
Bug 1411476. P3 - show a more descriptive message in DecodeError().

https://reviewboard.mozilla.org/r/192802/#review198074
Attachment #8921774 - Flags: review?(gsquelart) → review+
Comment on attachment 8921775 [details]
Bug 1411476. P4 - rewrite GetDebugInfo() functions to make string concatenation easier.

https://reviewboard.mozilla.org/r/192804/#review198076
Attachment #8921775 - Flags: review?(gsquelart) → review+
Comment on attachment 8921776 [details]
Bug 1411476. P5 - dump debug info for ChannelMediaResource.

https://reviewboard.mozilla.org/r/192806/#review198078
Attachment #8921776 - Flags: review?(gsquelart) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b9b85bd44aa
P1 - add a space before mAudioCompleted and run clang-format. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b197f21686c7
P2 - show duration in debug logs. r=gerald
https://hg.mozilla.org/integration/autoland/rev/a95d5ff230bc
P3 - show a more descriptive message in DecodeError(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/dfaab2423219
P4 - rewrite GetDebugInfo() functions to make string concatenation easier. r=gerald
https://hg.mozilla.org/integration/autoland/rev/3a04b939c55a
P5 - dump debug info for ChannelMediaResource. r=gerald
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: