1411476 - Add logs to debug test_bug495145.html timeout

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1404373#c10.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1411476. P1 - add a space before mAudioCompleted and run clang-format.

Review commit: https://reviewboard.mozilla.org/r/192798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192798/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1411476. P2 - show duration in debug logs.

Review commit: https://reviewboard.mozilla.org/r/192800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192800/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1411476. P3 - show a more descriptive message in DecodeError().

Review commit: https://reviewboard.mozilla.org/r/192802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192802/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1411476. P4 - rewrite GetDebugInfo() functions to make string concatenation easier.

Review commit: https://reviewboard.mozilla.org/r/192804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192804/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1411476. P5 - dump debug info for ChannelMediaResource.

Review commit: https://reviewboard.mozilla.org/r/192806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192806/

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8921772 [details]
Bug 1411476. P1 - add a space before mAudioCompleted and run clang-format.

https://reviewboard.mozilla.org/r/192798/#review198066

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8921773 [details]
Bug 1411476. P2 - show duration in debug logs.

https://reviewboard.mozilla.org/r/192800/#review198072

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8921774 [details]
Bug 1411476. P3 - show a more descriptive message in DecodeError().

https://reviewboard.mozilla.org/r/192802/#review198074

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8921775 [details]
Bug 1411476. P4 - rewrite GetDebugInfo() functions to make string concatenation easier.

https://reviewboard.mozilla.org/r/192804/#review198076

Comment 10

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8921776 [details]
Bug 1411476. P5 - dump debug info for ChannelMediaResource.

https://reviewboard.mozilla.org/r/192806/#review198078

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b9b85bd44aa
P1 - add a space before mAudioCompleted and run clang-format. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b197f21686c7
P2 - show duration in debug logs. r=gerald
https://hg.mozilla.org/integration/autoland/rev/a95d5ff230bc
P3 - show a more descriptive message in DecodeError(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/dfaab2423219
P4 - rewrite GetDebugInfo() functions to make string concatenation easier. r=gerald
https://hg.mozilla.org/integration/autoland/rev/3a04b939c55a
P5 - dump debug info for ChannelMediaResource. r=gerald

Comment 13

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/1b9b85bd44aa
https://hg.mozilla.org/mozilla-central/rev/b197f21686c7
https://hg.mozilla.org/mozilla-central/rev/a95d5ff230bc
https://hg.mozilla.org/mozilla-central/rev/dfaab2423219
https://hg.mozilla.org/mozilla-central/rev/3a04b939c55a