Closed
Bug 1411476
Opened 7 years ago
Closed 7 years ago
Add logs to debug test_bug495145.html timeout
Categories
(Core :: Audio/Video: Playback, enhancement, P5)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8921772 -
Flags: review?(gsquelart)
Attachment #8921773 -
Flags: review?(gsquelart)
Attachment #8921774 -
Flags: review?(gsquelart)
Attachment #8921775 -
Flags: review?(gsquelart)
Attachment #8921776 -
Flags: review?(gsquelart)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8921772 [details] Bug 1411476. P1 - add a space before mAudioCompleted and run clang-format. https://reviewboard.mozilla.org/r/192798/#review198066
Attachment #8921772 -
Flags: review?(gsquelart) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8921773 [details] Bug 1411476. P2 - show duration in debug logs. https://reviewboard.mozilla.org/r/192800/#review198072
Attachment #8921773 -
Flags: review?(gsquelart) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8921774 [details] Bug 1411476. P3 - show a more descriptive message in DecodeError(). https://reviewboard.mozilla.org/r/192802/#review198074
Attachment #8921774 -
Flags: review?(gsquelart) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8921775 [details] Bug 1411476. P4 - rewrite GetDebugInfo() functions to make string concatenation easier. https://reviewboard.mozilla.org/r/192804/#review198076
Attachment #8921775 -
Flags: review?(gsquelart) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8921776 [details] Bug 1411476. P5 - dump debug info for ChannelMediaResource. https://reviewboard.mozilla.org/r/192806/#review198078
Attachment #8921776 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 11•7 years ago
|
||
Thanks for the review!
Comment 12•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b9b85bd44aa P1 - add a space before mAudioCompleted and run clang-format. r=gerald https://hg.mozilla.org/integration/autoland/rev/b197f21686c7 P2 - show duration in debug logs. r=gerald https://hg.mozilla.org/integration/autoland/rev/a95d5ff230bc P3 - show a more descriptive message in DecodeError(). r=gerald https://hg.mozilla.org/integration/autoland/rev/dfaab2423219 P4 - rewrite GetDebugInfo() functions to make string concatenation easier. r=gerald https://hg.mozilla.org/integration/autoland/rev/3a04b939c55a P5 - dump debug info for ChannelMediaResource. r=gerald
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b9b85bd44aa https://hg.mozilla.org/mozilla-central/rev/b197f21686c7 https://hg.mozilla.org/mozilla-central/rev/a95d5ff230bc https://hg.mozilla.org/mozilla-central/rev/dfaab2423219 https://hg.mozilla.org/mozilla-central/rev/3a04b939c55a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•