1411481 - SkiaGL canvas is not used on Mac

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Sotaro Ikeda [:sotaro]]

On Mac, SkiaGL canvas is enabled, but it is not used when WebRender is enabled.

Comment 1

[Nicolas Silva [:nical]]

This is blocking stage-wr-next, is it because we may ship WebRender on Windows first, or are we OK with shipping with skiagl disabled during one release on Mac? I believe we also have the equivalent problem with D2D on windows, is D2D canvas a candidate for stage-wr-next?

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes to your first question; I'd like a yes to the second question as well, but for now we definitely want D2D canvas out of the current release we're working on, even if it ends up blocking the actual WebRender release.  In other words, if there is a D2D canvas specific WR bug, it can wait for a bit.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable SkiaGL canvas usage

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccd775b8522145eebb632724b664bcb8e3cc8940

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable SkiaGL canvas usage on Mac

Rebased.

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25eca9784d41d335b5a778deafde2110ae83089d

Comment 8

[Sotaro Ikeda [:sotaro]]

Hmm, attachment 8960414 [details] [diff] [review] does not render fishbowl correctly :(

> testdrive-archive.azurewebsites.net/performance/fishbowl,

Comment 9

[Darkspirit]

Attachment: debian.png

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> Hmm, attachment 8960414 [details] [diff] [review] does not render fishbowl correctly :(
How does it look? :/

try build from comment 7 on Debian Testing (Radeon RX480)
left:  gfx.webrender.all:true gfx.canvas.azure.accelerated:true  750 Fish @ 54 fps
right: gfx.webrender.all:true gfx.canvas.azure.accelerated:false 100 Fish @  9 fps

Comment 10

[Sotaro Ikeda [:sotaro]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #9)
> Created attachment 8960439 [details]
> debian.png
> 
> (In reply to Sotaro Ikeda [:sotaro] from comment #8)
> > Hmm, attachment 8960414 [details] [diff] [review] does not render fishbowl correctly :(
> How does it look? :/

Fish was not rendered correctly. It seemed that GL rendering was not finished yet.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: fishbowl problem

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> > (In reply to Sotaro Ikeda [:sotaro] from comment #8)
> > > Hmm, attachment 8960414 [details] [diff] [review] does not render fishbowl correctly :(
> > How does it look? :/
> 
> Fish was not rendered correctly. It seemed that GL rendering was not
> finished yet.

On my mac, somehow MacIOSurface rendering seems not work with WebRender. Even simple WebGL samples were not rendered.

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> 
> On my mac, somehow MacIOSurface rendering seems not work with WebRender.
> Even simple WebGL samples were not rendered.

attachment 8960414 [details] [diff] [review] seems not related to the MacIOSurface rendering problem.

Comment 14

[Sotaro Ikeda [:sotaro]]

Bug 1447245 was created for Comment 13.

Comment 15

[Sotaro Ikeda [:sotaro]]

With Comment 9, attachment 8960414 [details] [diff] [review] seems to work well.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aeb1fc7be33
Enable SkiaGL canvas usage on Mac r=jrmuizel

Comment 17

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1aeb1fc7be33