1411498 - Delete old sipcc code

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1411498: delete unused sipcc states.

Review commit: https://reviewboard.mozilla.org/r/192780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192780/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198142

::: dom/media/PeerConnection.js:1541
(Diff revision 1)
>        case "ReadyState":
>          // No-op
>          break;
>  

Can this go also?

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192780/diff/1-2/

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198142

> Can this go also?

I noticed that too. We don't use that state anywhere in our code, so I guess yes. Just deleted it and started a try run.
I was wondering if this is some generic DOM thing. But then hopefully the DOM/WebIDL review is going to tell me that :-)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198474

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4ff82ee1cda
delete unused sipcc states. r=bwc,smaug

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4ff82ee1cda