Closed Bug 1411498 Opened 7 years ago Closed 7 years ago

Delete old sipcc code

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

      No description provided.
Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198142

::: dom/media/PeerConnection.js:1541
(Diff revision 1)
>        case "ReadyState":
>          // No-op
>          break;
>  

Can this go also?
Attachment #8921760 - Flags: review?(docfaraday) → review+
Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198142

> Can this go also?

I noticed that too. We don't use that state anywhere in our code, so I guess yes. Just deleted it and started a try run.
I was wondering if this is some generic DOM thing. But then hopefully the DOM/WebIDL review is going to tell me that :-)
Attachment #8921760 - Flags: review?(bugs)
Comment on attachment 8921760 [details]
Bug 1411498: delete unused sipcc states.

https://reviewboard.mozilla.org/r/192780/#review198474
Attachment #8921760 - Flags: review?(bugs) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/e4ff82ee1cda
delete unused sipcc states. r=bwc,smaug
https://hg.mozilla.org/mozilla-central/rev/e4ff82ee1cda
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: