1411502 - Enable browser_jsterm_copy_command.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1411502 - Enable browser_jsterm_copy_command.js in new frontend; .

Review commit: https://reviewboard.mozilla.org/r/192816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192816/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8921809 [details]
Bug 1411502 - Enable browser_jsterm_copy_command.js in new frontend; .

https://reviewboard.mozilla.org/r/192816/#review198064

Green for me, just two nits

R+

Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_copy_command.js:29
(Diff revision 1)
> -                  [RANDOM, RANDOM],
> -                  [JSON.stringify(string), string],
> -                  [obj.toSource(), JSON.stringify(obj, null, "  ")],
> -    [
> -      "$('#" + ID + "')",
> -      content.document.getElementById(ID).outerHTML
> +    <p id="${id}">${text}</p>
> +  </div>
> +  <div><p></p></div>
> +</body>`;
> +
> +add_task(async function() {

space between function and ()

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_copy_command.js:54
(Diff revision 1)
> -  gBrowser.removeTab(gBrowser.selectedTab);
> -  finishTest();
> -});
> +    info(`Attempting to copy: "${stringToCopy}"`);
> +    const command = `copy(${stringToCopy})`;
> +    info(`Executing command: "${command}"`);
> +    jsterm.execute(command);
> +  }, expectedResult);
> +}

There should be a new line at the end.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8921809 [details]
Bug 1411502 - Enable browser_jsterm_copy_command.js in new frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192816/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b655a076c99
Enable browser_jsterm_copy_command.js in new frontend; r=Honza.

Comment 5

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/1b655a076c99