1411518 - Update follow-on search add-on to 0.9.6

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

We want to push the latest version of the follow-on search add-on to nightly & beta, ready for FF 57

https://github.com/mozilla/followonsearch/releases/tag/v0.9.6

This includes:

- Fixes to handling of Yahoo search telemetry following changes on the Yahoo servers.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1411518 - Update follow-on search add-on to 0.9.6.

Review commit: https://reviewboard.mozilla.org/r/192854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192854/

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

https://reviewboard.mozilla.org/r/192854/#review198070

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/007f61e8f2c5
Update follow-on search add-on to 0.9.6. r=past

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

[Tracking Requested - why for this release]: important data collection fix that will be pushed to release via Go Faster in bug 1409491

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/007f61e8f2c5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval ASAP.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

Approval Request Comment
[Feature/Bug causing the regression]: Follow-on search. Yahoo changed how their servers work for searching, and affected the telemetry.
[User impact if declined]: None. This is only impacting our telemetry collecting (which is important).
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: I just verified it.
[Needs manual test from QE? If yes, steps to reproduce]: No. Version 0.9.6 of the add-on has already been verified by QE, see bug 1409491 comment 10.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change to telemetry handling only.
[String changes made/needed]: None

Comment 8

[Julien Cristau [:jcristau]]

bug 1409491 comment 10 is fairly light on details about what was tested (firefox version, platforms, etc...)

Comment 9

[Mike Kaply [:mkaply]]

(In reply to Julien Cristau [:jcristau] from comment #8)
> bug 1409491 comment 10 is fairly light on details about what was tested
> (firefox version, platforms, etc...)

There's a full test plan that Justin is testing. The changes for this version were very small (related to Yahoo URL changes).

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

Must fix, it's a bit late in beta cycle, the risk is limited to follow-on search-on, Beta57+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18fc5fc8bf7c