Update follow-on search add-on to 0.9.6

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox57+ fixed, firefox58 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Description

2 years ago
We want to push the latest version of the follow-on search add-on to nightly & beta, ready for FF 57

https://github.com/mozilla/followonsearch/releases/tag/v0.9.6

This includes:

- Fixes to handling of Yahoo search telemetry following changes on the Yahoo servers.
Assignee

Updated

2 years ago
See Also: → 1409491
Comment hidden (mozreview-request)
Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

https://reviewboard.mozilla.org/r/192854/#review198070

LGTM
Attachment #8921821 - Flags: review?(past) → review+

Comment 3

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/007f61e8f2c5
Update follow-on search add-on to 0.9.6. r=past
[Tracking Requested - why for this release]: important data collection fix that will be pushed to release via Go Faster in bug 1409491
https://hg.mozilla.org/mozilla-central/rev/007f61e8f2c5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Please nominate this for Beta approval ASAP.
Flags: needinfo?(standard8)
Assignee

Comment 7

2 years ago
Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

Approval Request Comment
[Feature/Bug causing the regression]: Follow-on search. Yahoo changed how their servers work for searching, and affected the telemetry.
[User impact if declined]: None. This is only impacting our telemetry collecting (which is important).
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: I just verified it.
[Needs manual test from QE? If yes, steps to reproduce]: No. Version 0.9.6 of the add-on has already been verified by QE, see bug 1409491 comment 10.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change to telemetry handling only.
[String changes made/needed]: None
Flags: needinfo?(standard8)
Attachment #8921821 - Flags: approval-mozilla-beta?
bug 1409491 comment 10 is fairly light on details about what was tested (firefox version, platforms, etc...)
(In reply to Julien Cristau [:jcristau] from comment #8)
> bug 1409491 comment 10 is fairly light on details about what was tested
> (firefox version, platforms, etc...)

There's a full test plan that Justin is testing. The changes for this version were very small (related to Yahoo URL changes).
Comment on attachment 8921821 [details]
Bug 1411518 - Update follow-on search add-on to 0.9.6.

Must fix, it's a bit late in beta cycle, the risk is limited to follow-on search-on, Beta57+
Attachment #8921821 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.