1411618 - Remove trailing periods for error: tab crash choices

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P2)

Description

[Ton [:Tonnes]]

Attachment: bug_1394458_periods.patch

Following up on bug 1394458, this should remove the trailing periods in user choices for the tab crash error page.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8921912 [details] [diff] [review]
bug_1394458_periods.patch

Review of attachment 8921912 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, as far as the code goes.

Comment 2

[Ton [:Tonnes]]

Anything else needed before checking this in?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Ton from comment #2)
> Anything else needed before checking this in?

There is a pending r? and NI for Michelle. Once that's done, you can set the checkin-needed keyword.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Tonnes, could you have a look please?

Comment 5

[Ton [:Tonnes]]

Afaik there was a pending r? in addition to the r+. Also and given the long inactivity (new file changes) as well as the move to ftl files, the current r+ patch is outdated. Tbh it would take me quite some time to update the source, investigate, test and create a new one.

Is anyone else willing to create a patch, possibly within a couple of minutes?

Comment 6

[mheubusch]

Reviewed - this is fine.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Nihanth, this now has sign-off, would you be willing to rebase this patch?

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Ethan, I believe this is an old patch that updates some copy. I am currently trying to clear out my backlog/queue so I'm forwarding this to you for re-prioritization for our team. The patch just needs to be rebased onto latest tree and landed. Could you help find an owner for this (even if it ends up being me)?

Comment 9

[Ethan Tseng [:ethan]]

Nihanth, this bug is not urgent. But please take some time to update and land the patch. Thanks!

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1411618 - Remove trailing periods for error: tab crash choices. r=jaws!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95981e55392b
Remove trailing periods for error: tab crash choices. r=jaws,fluent-reviewers,flod

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/95981e55392b