Closed
Bug 1411642
Opened 7 years ago
Closed 7 years ago
Hovered close button overflows by 1px
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | verified |
People
(Reporter: Oriol, Assigned: dao)
References
Details
(Keywords: regression, Whiteboard: [reserve-photon-visual])
Attachments
(2 files)
Hover the close button, it gets a red background. But it's 1px too tall. Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7d3f5015ac7e35796e6b3595e56d20cec64b9ff0&tochange=f5121cba7d7b5031d69bcc7179c227c1858265a5
Assignee | ||
Comment 1•7 years ago
|
||
This is on Windows 10, I suppose? What are your DPI settings?
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(oriol-bugzilla)
Priority: -- → P1
Whiteboard: [reserve-photon-visual]
Reporter | ||
Comment 2•7 years ago
|
||
Yes, Windows 10 1703 x64 with 100% DPI.
Flags: needinfo?(oriol-bugzilla)
Assignee | ||
Updated•7 years ago
|
OS: Unspecified → Windows 10
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8922255 [details] Bug 1411642 - Don't let window controls overlap the nav bar. https://reviewboard.mozilla.org/r/193292/#review198512 Good that we can remove this workaround. Thanks!
Attachment #8922255 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe42b971c838 Don't let window controls overlap the nav bar. r=johannh
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fe42b971c838
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify+
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 8•7 years ago
|
||
I verified this issue using Nightly 58.0a1 with Build ID 20171102222620 on Windows 10 x64. I will mark this as verified fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•