1411642 - Hovered close button overflows by 1px

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Attachment: screenshot.png

Hover the close button, it gets a red background.
But it's 1px too tall.

Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7d3f5015ac7e35796e6b3595e56d20cec64b9ff0&tochange=f5121cba7d7b5031d69bcc7179c227c1858265a5

Comment 1

[Dão Gottwald [:dao]]

This is on Windows 10, I suppose? What are your DPI settings?

Comment 2

[Oriol Brufau [:Oriol]]

Yes, Windows 10 1703 x64 with 100% DPI.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1411642 - Don't let window controls overlap the nav bar.

Review commit: https://reviewboard.mozilla.org/r/193292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193292/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8922255 [details]
Bug 1411642 - Don't let window controls overlap the nav bar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193292/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8922255 [details]
Bug 1411642 - Don't let window controls overlap the nav bar.

https://reviewboard.mozilla.org/r/193292/#review198512

Good that we can remove this workaround. Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe42b971c838
Don't let window controls overlap the nav bar. r=johannh

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fe42b971c838

Comment 8

[Valentina Claudia Ona]

I verified this issue using Nightly 58.0a1 with Build ID 20171102222620 on Windows 10 x64.
I will mark this as verified fixed.