Crash in TabManager.removeTab() caused by window.close()

RESOLVED FIXED

Status

()

Firefox for iOS
Browser
P1
critical
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0)

Details

Attachments

(2 attachments)

(Assignee)

Description

a month ago
The following crash occurred in a BuddyBuild Enterprise build on master:

Thread 0 Crashed:
0 	libswiftCore​.dylib 	
	globalinit_33_FD9A49A256BEB6AF7C48013347ADC3BA_func6
	
1 	Client 	TabManager.swift ​Line ​0
	_T06Client10TabManagerC06removeB033_932D52E6383C2B96DB066936B32B3140LLyAA0B0C_Sb11flushToDiskSb6notifytF
	
2 	Client 	TabManager.swift ​Line ​344
	_T06Client10TabManagerC06removeB0yAA0B0CF
	
3 	Client 	BrowserViewController.swift ​Line ​1605
	_T06Client21BrowserViewControllerC17windowCloseHelperyAA06WindowfG0C_AA3TabC012didRequestTofI0tF
	
4 	Client 	BrowserViewController.swift ​Line ​0
	_T06Client21BrowserViewControllerCAA25WindowCloseHelperDelegateA2aDP06windowfG0yAA0efG0C_AA3TabC012didRequestTofJ0tFTW
	
5 	Client 	WindowCloseHelper.swift ​Line ​0
	_T06Client17WindowCloseHelperC21userContentControllerySo06WKUserfG0C_So15WKScriptMessageC016didReceiveScriptJ0tFyycfU_
	
6 	Client 	AppSettingsTableViewController.swift ​Line ​0
	_T0Ix_IyB_TR
	
7 	libdispatch​.dylib 	
	_dispatch_call_block_and_release
	
8 	libdispatch​.dylib 	
	_dispatch_client_callout
	
9 	libdispatch​.dylib 	
	_dispatch_main_queue_callback_4CF$VARIANT$mp
	
10 	CoreFoundation 	
	__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
	
11 	CoreFoundation 	
	__CFRunLoopRun
	
12 	CoreFoundation 	
	CFRunLoopRunSpecific
	
13 	GraphicsServices 	
	GSEventRunModal
	
14 	UIKit 	
	UIApplicationMain
	
15 	Client 	main.swift ​Line ​0
	main
	
16 	libdyld​.dylib 	
	start
(Assignee)

Comment 1

a month ago
Created attachment 8921965 [details]
nslogs.txt
(Assignee)

Updated

a month ago
Assignee: nobody → jdarcangelo
Severity: normal → major
Status: NEW → ASSIGNED
tracking-fxios: ? → 10.0
Priority: -- → P1
(Assignee)

Updated

a month ago
Severity: major → critical
(Assignee)

Updated

a month ago
See Also: → bug 1386874
(Assignee)

Comment 2

a month ago
Created attachment 8921967 [details] [review]
GitHub Pull Request
Attachment #8921967 - Flags: review?(fpatel)
(Assignee)

Updated

a month ago
Attachment #8921967 - Flags: review?(fpatel)
(Assignee)

Updated

a month ago
Attachment #8921967 - Flags: review?(fpatel)

Updated

a month ago
Attachment #8921967 - Flags: review?(fpatel) → review+
(Assignee)

Comment 3

a month ago
Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/23cd239ad073307a984a5855901d5e49a52621ad

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/3d83861639e0eb3a6b12bfce838784eed823508d
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.