1411680 - fix clang toolchain downloaded by `mach bootstrap` on Linux; r=build-peer

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

We renamed this toolchain a while back, but never updated bootstrap.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: fix clang toolchain downloaded by `mach bootstrap` on Linux; r=build-peer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9d8d96e403
fix clang toolchain downloaded by `mach bootstrap` on Linux; r=nalexander

Comment 3

[Mike Hommey [:glandium]]

Please back this out. linux64-clang is an alias, and it's meant to work. If it doesn't then we need to fix that.

Comment 4

[Mike Hommey [:glandium]]

In fact, it works.
./mach artifact toolchain --from-build linux64-clang
 0:06.20 Downloading clang.tar.xz

Comment 5

[Nathan Froyd [:froydnj]]

We apparently need to fix things, then, because the motivation for this patch:

Could not find artifacts for a toolchain build named `linux64-clang`
Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '['/usr/bin/python', u'/home/froydnj/src/gecko-dev.git/mach', u'artifact', u'toolchain', u'--from-build', u'linux64-clang']' returned non-zero exit status 1

  File "/home/froydnj/src/gecko-dev.git/python/mozboot/mozboot/mach_commands.py", line 32, in bootstrap
    bootstrapper.bootstrap()
  File "/home/froydnj/src/gecko-dev.git/python/mozboot/mozboot/bootstrap.py", line 372, in bootstrap
    self.instance.ensure_stylo_packages(state_dir, checkout_root)
  File "/home/froydnj/src/gecko-dev.git/python/mozboot/mozboot/linux_common.py", line 18, in ensure_stylo_packages
    self.install_toolchain_artifact(state_dir, checkout_root, stylo.LINUX)
  File "/home/froydnj/src/gecko-dev.git/python/mozboot/mozboot/base.py", line 285, in install_toolchain_artifact
    subprocess.check_call(cmd, cwd=state_dir)
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)

Comment 6

[Mike Hommey [:glandium]]

Did you make local changes to build/build-clang, or any other file involved in those builds?

Comment 7

[Mike Hommey [:glandium]]

Because, not it says it couldn't find artifacts, not that it couldn't find the task, which is what would happen if it didn't know about the name:

$ ./mach artifact toolchain --from-build foo
 0:03.96 Could not find a toolchain build named `foo`

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #6)
> Did you make local changes to build/build-clang, or any other file involved
> in those builds?

I probably do.  Why should that matter?

Comment 9

[Mike Hommey [:glandium]]

See bug 1406346 comment 1.

Comment 10

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/8d9d8d96e403

Comment 11

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Please back this out. linux64-clang is an alias, and it's meant to work. If
> it doesn't then we need to fix that.

Done in https://hg.mozilla.org/integration/mozilla-inbound/rev/94eb916b687089b260c020cdccf8974042955dc4