Closed
Bug 1411694
Opened 7 years ago
Closed 7 years ago
add an override declaration in WebrtcMediaCodecVP8VideoCodec
Categories
(Core :: Audio/Video, enhancement)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
We have override declarations for lots of other overriden virtual
functions, but not this one.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8922045 -
Flags: review?(rjesup)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8922045 [details] [diff] [review]
add an override declaration in WebrtcMediaCodecVP8VideoCodec
Review of attachment 8922045 [details] [diff] [review]:
-----------------------------------------------------------------
Odd this wasn't flagged earlier
Attachment #8922045 -
Flags: review?(rjesup) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae8e4b61b8f6
add an override declaration in WebrtcMediaCodecVP8VideoCodec; r=jesup
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•