1411742 - Remove unused prefs and member variables in media.getusermedia

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Tom Ritter [:tjr] (ooto until 9/1)]

The following items seem not to actually be used in the codebase, just moved around. We can remove all mention of them:

media.getusermedia.aec_extended_filter
media.getusermedia.aec_aec_delay_agnostic
media.navigator.video.default_minfps
The fullDuplex member of MediaEnginePrefs (and possibly the pref media.navigator.audio.full_duplex)
media.getusermedia.playout_delay
media.getusermedia.screensharing.allowed_domains

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yes.

Comment 2

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1411742 Remove the media.navigator.video.default_minfps pref and all uses of it as the field is never actually used

Review commit: https://reviewboard.mozilla.org/r/193436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193436/

Comment 3

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1411742 Remove the pref media.getusermedia.playout_delay and the field as they are not used anywhere

Review commit: https://reviewboard.mozilla.org/r/193438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193438/

Comment 4

[Tom Ritter [:tjr] (ooto until 9/1)]

Attachment: Bug 1411742 Remove all references to media.getusermedia.screensharing.allowed_domains as we have removed all uses of it in the code

Review commit: https://reviewboard.mozilla.org/r/193440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193440/

Comment 5

[Tom Ritter [:tjr] (ooto until 9/1)]

So half of those did turn out to be used =)

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e161ae13b0f8ecb02109e89b26ef77fdd0dd6af4

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8922408 [details]
Bug 1411742 Remove the media.navigator.video.default_minfps pref and all uses of it as the field is never actually used

https://reviewboard.mozilla.org/r/193436/#review205718

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8922409 [details]
Bug 1411742 Remove the pref media.getusermedia.playout_delay and the field as they are not used anywhere

https://reviewboard.mozilla.org/r/193438/#review205728

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8922410 [details]
Bug 1411742 Remove all references to media.getusermedia.screensharing.allowed_domains as we have removed all uses of it in the code

https://reviewboard.mozilla.org/r/193440/#review205734

Comment 9

[Tom Ritter [:tjr] (ooto until 9/1)]

Comment on attachment 8922408 [details]
Bug 1411742 Remove the media.navigator.video.default_minfps pref and all uses of it as the field is never actually used

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193436/diff/1-2/

Comment 10

[Tom Ritter [:tjr] (ooto until 9/1)]

Comment on attachment 8922409 [details]
Bug 1411742 Remove the pref media.getusermedia.playout_delay and the field as they are not used anywhere

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193438/diff/1-2/

Comment 11

[Tom Ritter [:tjr] (ooto until 9/1)]

Comment on attachment 8922410 [details]
Bug 1411742 Remove all references to media.getusermedia.screensharing.allowed_domains as we have removed all uses of it in the code

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/193440/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef28f0994646
Remove the media.navigator.video.default_minfps pref and all uses of it as the field is never actually used r=jib
https://hg.mozilla.org/integration/autoland/rev/d82696a3e259
Remove the pref media.getusermedia.playout_delay and the field as they are not used anywhere r=jib
https://hg.mozilla.org/integration/autoland/rev/36ee1d2ea39d
Remove all references to media.getusermedia.screensharing.allowed_domains as we have removed all uses of it in the code r=jib

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ef28f0994646
https://hg.mozilla.org/mozilla-central/rev/d82696a3e259
https://hg.mozilla.org/mozilla-central/rev/36ee1d2ea39d

Comment 14

[Gerry Chang [:gchang]]

Won't fix for 58 and let it ride the train.