1411749 - Follow-up: fix testActivityStreamPocketReferrer after Pocket feature flag implementation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Activity Stream, defect, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I forgot to update it in bug 1411657 and no one is backing out the failure so I'm going to fix the test here and land on top.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from bug 1411657 comment #12)
> (In reply to Michael Comella (:mcomella) from comment #10)
> > (In reply to Michael Comella (:mcomella) from comment #9)
> > > My push is going to fail because I forgot to update
> > > testActivityStreamPocketReferrer.
> > 
> > It only ran rc4 so maybe not.
> 
> rc3 in the job after mine failed:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=184c3c90cf23323a822f979d4cff1e10d629e245&selected
> Job=139610064

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

Review commit: https://reviewboard.mozilla.org/r/193082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193082/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

https://reviewboard.mozilla.org/r/193082/#review198332

Moving forward r+ from https://bugzilla.mozilla.org/show_bug.cgi?id=1411657#c13

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e25e31838c
Disable testActivityStreamPocketReferrer when Pocket is disabled by default. r=mcomella

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

Approval Request Comment: see bug 1411657 comment 8.

[List of other uplifts needed for the feature/fix]: bug 1411657 must be landed first.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI Sylvestre to make sure this gets uplifted with bug 1411657.

Sorry for the messy landing: CI wasn't doing what I needed it to do.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

just like in the other bug!

Comment 8

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/17e25e31838c

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

This is needed for bug 1411657, Beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0153d5be6150