Follow-up: fix testActivityStreamPocketReferrer after Pocket feature flag implementation

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 58
All
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

Attachments

(1 attachment)

I forgot to update it in bug 1411657 and no one is backing out the failure so I'm going to fix the test here and land on top.
Priority: -- → P1
(In reply to Michael Comella (:mcomella) from bug 1411657 comment #12)
> (In reply to Michael Comella (:mcomella) from comment #10)
> > (In reply to Michael Comella (:mcomella) from comment #9)
> > > My push is going to fail because I forgot to update
> > > testActivityStreamPocketReferrer.
> > 
> > It only ran rc4 so maybe not.
> 
> rc3 in the job after mine failed:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=184c3c90cf23323a822f979d4cff1e10d629e245&selected
> Job=139610064
Assignee

Comment 3

2 years ago
mozreview-review
Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

https://reviewboard.mozilla.org/r/193082/#review198332

Moving forward r+ from https://bugzilla.mozilla.org/show_bug.cgi?id=1411657#c13
Attachment #8922080 - Flags: review+

Comment 4

2 years ago
Pushed by michael.l.comella@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/17e25e31838c
Disable testActivityStreamPocketReferrer when Pocket is disabled by default. r=mcomella
Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

Approval Request Comment: see bug 1411657 comment 8.

[List of other uplifts needed for the feature/fix]: bug 1411657 must be landed first.
Attachment #8922080 - Flags: review?(liuche) → approval-mozilla-beta?
NI Sylvestre to make sure this gets uplifted with bug 1411657.

Sorry for the messy landing: CI wasn't doing what I needed it to do.
Flags: needinfo?(sledru)
Summary: Follow-up: fix testActivityStreamPocketReferrer → Follow-up: fix testActivityStreamPocketReferrer after Pocket feature flag implementation
just like in the other bug!
Flags: needinfo?(sledru) → needinfo?(rkothari)

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/17e25e31838c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Flags: needinfo?(rkothari)
Comment on attachment 8922080 [details]
Bug 1411749: Disable testActivityStreamPocketReferrer when Pocket is disabled by default.

This is needed for bug 1411657, Beta57+
Attachment #8922080 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.