In the past week or so, the taskbar hasn't been hiding as it should when Nightly or a video in NIghtly is fullscreen
Categories
(Core :: Widget: Win32, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | unaffected |
People
(Reporter: jed-development, Unassigned)
Details
Comment 1•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment 6•8 years ago
|
||
![]() |
||
Updated•8 years ago
|
Comment 8•5 years ago
|
||
I'm running the latest Firefox release (71.0) on Win10/x64. I've noticed that sometimes, when I go to full screen mode in YouTube/Netflix, the taskbar will remain and overlap the video. This does not happen all the time. Sometimes I can make this behaviour go away by one or more of the following: switching to another window and switching back; clicking the start menu; mini/maximising Firefox; etc. I haven't yet found the exact sequence of events that triggers this issue nor the exact sequence of actions I need to undertake to fix/workaround this issue. It seems as though it happens randomly but I have a feeling there is some reason for this happening. I am at a bit of a loss as to what that reason might be but I am more than happy to provide any details that could help track down the issue.
Updated•3 years ago
|
I can confirm this issue is occuring on both Windows 10 and 11. I maintain a custom compiled release product from upstream Nighly and my latest build has been facing this issue across all Windows devices: https://github.com/CYFARE/HellFire/issues/13
Hg pull and update date: 2025-03-06
Following is the mozconfig used:
# MOZCONFIG for "HellFire Lazer" Windows Build
# Build Configs
ac_add_options --enable-application=browser
ac_add_options --disable-artifact-builds
# Settings :: Optimizations
#ac_add_options MOZ_PGO=1
ac_add_options --enable-release
ac_add_options --disable-debug
ac_add_options --disable-debug-symbols
ac_add_options --disable-debug-js-modules
ac_add_options --disable-tests
ac_add_options --enable-strip
ac_add_options --enable-install-strip
ac_add_options --enable-clang-plugin
ac_add_options --enable-wasm-avx
ac_add_options --enable-rust-simd
ac_add_options --disable-parental-controls
ac_add_options --disable-crashreporter
ac_add_options --disable-updater
ac_add_options --disable-maintenance-service
ac_add_options --disable-bits-download
ac_add_options --disable-update-agent
ac_add_options --enable-jemalloc
ac_add_options --enable-raw
ac_add_options --enable-webrtc
ac_add_options --enable-jxl
ac_add_options --enable-av1
ac_add_options --enable-eme=widevine
ac_add_options --enable-hardening
ac_add_options --enable-sandbox
mk_add_options MOZ_PARALLEL_COMPILE=16
mk_add_options MOZ_PARALLEL_BUILD=16
mk_add_options MOZ_CRASHREPORTER=0
mk_add_options MOZ_DATA_REPORTING=0
mk_add_options MOZ_SERVICES_HEALTHREPORT=0
mk_add_options MOZ_TELEMETRY_REPORTING=0
export RUSTFLAGS="-C opt-level=3 -C target-cpu=x86-64-v3 -C codegen-units=1 -Cpanic=abort -Cforce-frame-pointers=no -Cllvm-args=--inline-threshold=1000 -Cllvm-args=-vectorize-loops -Cllvm-args=-vectorize-slp"
export CFLAGS="-O3 -march=x86-64-v3 -mavx2 -maes -msse4.2 -fno-semantic-interposition -fomit-frame-pointer -fdata-sections -ffunction-sections -fno-plt -funroll-loops $CFLAGS"
export CXXFLAGS="$CFLAGS"
export LDFLAGS="-Wl,-O3 -Wl,--gc-sections -Wl,-z,now -Wl,-z,relro -Wl,--icf=all $LDFLAGS"
# Compile Configs
mk_add_options AUTOCLOBBER=1
mk_add_options MOZ_MAKE_FLAGS="-j16"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir-opt
Apart from the taskbar, I also notice that if any youtube link is directly pasted after starting the browser (not visited via clicking the video link), then when the fullscreen button on video controls is pressed immediately before the video starts playing, video player is not set to fullscreen, but the youtube application (rest of the site) becomes fullscreen. In this issue, the taskbar bug also persists.
Comment 10•3 months ago
|
||
For reference, this is exactly the same as this user report: https://connect.mozilla.org/t5/discussions/going-fullscreen-in-youtube-or-netflix-doesn-t-hide-the-taskbar/td-p/89248
Updated•3 months ago
|
Updated•3 months ago
|
Comment 11•3 months ago
|
||
Issue is solved by implementing these about:config changes:
https://github.com/CYFARE/HellFire/issues/13#issuecomment-2707915761
Comment 12•3 months ago
|
||
Thanks, cyfare, that is a huge help. Can you still reproduce the issue if the prefs aren't changed? I can't reproduce it at all but I have a potential fix I'd like you to try, if you can still reproduce this.
Direct link to build: zip or installer exe
(Here is a link to the build job with the patches)
The link in comment 11 disables the FullscreenTransitionTask, which animates the fade-out/fade-in. The prefs to do this are:
- Set full-screen-api.transition-duration.enter and full-screen-api.transition-duration.leave to 0 0
- Set full-screen-api.warning.timeout to 0
I cannot get the taskbar to appear over YouTube videos in fullscreen, although I don't know if there is more steps to reproduce than to play a video fullscreen.
In bug 1952284 comment 9, rkraesig changed some full screen behavior to fix a similar browser issue that appeared in Windows recently. cyfare mentions there that this didn't fix the issue. The try build above adds the MarkAsHidingTaskbar
behavior to the fullscreen transition window -- it was formerly only on the browser window. This is just a theory atm.
Apart from the taskbar, I also notice that if any youtube link is directly pasted after starting the browser (not visited via clicking the video link), then when the fullscreen button on video controls is pressed immediately before the video starts playing, video player is not set to fullscreen, but the youtube application (rest of the site) becomes fullscreen. In this issue, the taskbar bug also persists.
This I can reproduce, by running a debug build. It seems to be timing related -- maybe there is a race involved in the completion of the full screen transition and the element going fullscreen.
Comment 13•3 months ago
|
||
(In reply to David Parks [:handyman] from comment #12)
Thanks, cyfare, that is a huge help. Can you still reproduce the issue if the prefs aren't changed? I can't reproduce it at all but I have a potential fix I'd like you to try, if you can still reproduce this.
Direct link to build: zip or installer exe
(Here is a link to the build job with the patches)
The link in comment 11 disables the FullscreenTransitionTask, which animates the fade-out/fade-in. The prefs to do this are:
- Set full-screen-api.transition-duration.enter and full-screen-api.transition-duration.leave to 0 0
- Set full-screen-api.warning.timeout to 0
I cannot get the taskbar to appear over YouTube videos in fullscreen, although I don't know if there is more steps to reproduce than to play a video fullscreen.
In bug 1952284 comment 9, rkraesig changed some full screen behavior to fix a similar browser issue that appeared in Windows recently. cyfare mentions there that this didn't fix the issue. The try build above adds the
MarkAsHidingTaskbar
behavior to the fullscreen transition window -- it was formerly only on the browser window. This is just a theory atm.Apart from the taskbar, I also notice that if any youtube link is directly pasted after starting the browser (not visited via clicking the video link), then when the fullscreen button on video controls is pressed immediately before the video starts playing, video player is not set to fullscreen, but the youtube application (rest of the site) becomes fullscreen. In this issue, the taskbar bug also persists.
This I can reproduce, by running a debug build. It seems to be timing related -- maybe there is a race involved in the completion of the full screen transition and the element going fullscreen.
Installed latest Nightly version from https://www.mozilla.org/firefox/channel/desktop/?utm_source=blog.nightly.mozilla.org&utm_medium=referral&utm_campaign=blog-nav#nightly (Windows) on fresh Win11 system and issue no longer exists. But the about:config settings mentioned above are unchanged. I'm curious what causes this, but well.. we've a mitigation atleast..
Comment 14•3 months ago
|
||
(In reply to cyfare from comment #13)
Installed latest Nightly version from https://www.mozilla.org/firefox/channel/desktop/?utm_source=blog.nightly.mozilla.org&utm_medium=referral&utm_campaign=blog-nav#nightly (Windows) on fresh Win11 system and issue no longer exists. But the about:config settings mentioned above are unchanged. I'm curious what causes this, but well.. we've a mitigation atleast..
I take this to mean that the bug is gone in the latest nightly -- and pref changes and other mitigations are no longer needed. I had personally seen different taskbar issues with a number of applications around the time these reappeared a few weeks ago and they seem to have gone away. This may have been due to an OS update.
Description
•