Open Bug 1411809 Opened 7 years ago Updated 2 years ago

Merge permission entries back into main app AndroidManifest.xml

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

All
Android
enhancement

Tracking

(firefox58 affected)

Tracking Status
firefox58 --- affected

People

(Reporter: maliu, Unassigned)

References

Details

(Keywords: good-first-bug)

We formerly build 2 APKs for different distribution purpose. Target.apk for normal release and bouncer.apk for some phone manufacturer partner. The main purpose of the bouncer.apk is to have a minimum APK preinstalled in a phone to reduce storage consumption and allow us to redirect users to google play to download actual full functional APK. 

The reason why we need to separate the permission entries from main app AndroidManifest.xml is because the app can only be granted with the  SystemOrSignature level permissions is through the in-rom APK, NOT through google play update. In order to assure that, we separate the permission from main app AndroidManifest.xml into mobile/android/base/FennecManifest_permissions.xml.in to allow both APKs reference to it. And compare the permissions between target.apk and bouncer.apk. If someone adds new permission in the main app but not the extracted one, the build will fail and indicates developers to move permission to correct place.

In Bug 1360587, we removed the bouncer APK so the separated permission declaration is no longer required. The goal for this bug is to merge the permission back to the AndroidManifest.xml in the main app.

See also 
https://bugzilla.mozilla.org/show_bug.cgi?id=1360587#c18
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Product: Firefox for Android → Firefox Build System
Severity: trivial → S4
You need to log in before you can comment on or make changes to this bug.