1411838 - Enable WebVR reftest for Windows debug

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Daosheng Mu[:daoshengmu]]

Because we have done the implementation of sending the TextureSurface from WebGL texture directly instead of CopySurface from it. We no longer hit the assertion of glError. We can enable our WebVR reftest for Windows debug now.

Comment 1

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #0)
 Because we have done the implementation of sending the SurfaceDescriptor from
> WebGL texture directly instead of CopySurface from it. We no longer hit the
> assertion of glError. We can enable our WebVR reftest for Windows debug now.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1411838 - Part 1: Enable WebVR reftest for Windows debug;

Review commit: https://reviewboard.mozilla.org/r/197936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197936/

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1411838 - Part 2: Fix non thread-safe objects in VR;

Review commit: https://reviewboard.mozilla.org/r/197938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197938/

Comment 4

[Daosheng Mu[:daoshengmu]]

After enabling the test in debug, it will happen an assertion. I notice the reason is that VRLayerParent is a weak pointer but be stored in a refptr array at VRDisplayHost. That will cause assertion when VRLayerParent is calling its destructor. That needs to be fixed by making the array as a weakptr array.


This bug needs to wait for Bug 1415762 land because the DispatchVREvents task need to be canceled when the thread is shutdown, otherwise, it would be dispatch to the main thread and hit an assertion that is not our intention.

Comment 5

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=9389ec3e1e3a8a63ce93469a13cc8f6ff68f519b

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8926689 [details]
Bug 1411838 - Part 1: Enable WebVR reftest for Windows debug;

https://reviewboard.mozilla.org/r/197936/#review203352

LGTM, Thanks!

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8926690 [details]
Bug 1411838 - Part 2: Fix non thread-safe objects in VR;

https://reviewboard.mozilla.org/r/197938/#review203354

Good catch, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dbb8758e13c
Part 1: Enable WebVR reftest for Windows debug; r=kip
https://hg.mozilla.org/integration/autoland/rev/c413c58c311d
Part 2: Fix non thread-safe objects in VR; r=kip

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6dbb8758e13c
https://hg.mozilla.org/mozilla-central/rev/c413c58c311d