1411920 - about:debugging needs to use ES6 classes so that we can switch it over to PureComponent

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P2)

Comment 1

[Julian Descottes [:jdescottes]]

Mike, I have a bunch of WIP patches at the moment for the about:debugging connect screen feature. I imagine this will make it a pain for me to rebase. 

Can we wait a bit until I start landing the main pieces for Bug 1243329 ?

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Julian Descottes [:jdescottes] from comment #1)
> Mike, I have a bunch of WIP patches at the moment for the about:debugging
> connect screen feature. I imagine this will make it a pain for me to rebase. 
> 
> Can we wait a bit until I start landing the main pieces for Bug 1243329 ?

Of course.

This is mostly straightforward but devtools/client/aboutdebugging/components/workers/Panel.js calls this.getInitialState(), which is not supported in ES6 classes.

I will fix this and do the full conversion when your bug lands.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1411920 - about:debugging to ES6 classes

Review commit: https://reviewboard.mozilla.org/r/195440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195440/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8924231 [details]
Bug 1411920 - about:debugging to ES6 classes

https://reviewboard.mozilla.org/r/195440/#review200918

LGTM Mike, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2326b69f91e
about:debugging to ES6 classes r=jdescottes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f2326b69f91e