Closed Bug 1411968 Opened 3 years ago Closed 2 years ago

Can't cancel/pause a download

Categories

(Firefox for Android :: Custom Tabs, defect, P2)

Firefox 57
ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
fennec + ---
firefox57 --- wontfix
firefox58 --- verified
firefox59 --- verified

People

(Reporter: sflorean, Assigned: jchen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Environment: 
Device: Huawei Honor (Android 5.1.1), Oneplus Two (Android 6.0.1);
Build: 57.0b11;
Prerequisites: enable Custom Tabs.

Steps to reproduce:
1. Go to https://www.thinkbroadband.com/download;
2. Download 2,3 items;
3. Tap on "Cancel" from notification bar.

Expected result:
The download is canceled/paused.

Actual result:
The download is still working and message is displayed. See the screenshots.
- for OnePlus https://i.imgur.com/mLCU6Hw.png
- for Huawei https://i.imgur.com/f80TTA8.png
It works with my Samsung S7 Edge (Android 7.0) & Pixel (Android 8.0) on 58 Nightly, 57 Beta, and 56 Release.

Would you help try few more device to know if this is some OEM specific? Thanks.
Flags: needinfo?(sorina.florean)
Tested on Samsung Galaxy Tab 3 (Android 7.0), Samsung Galaxy Note 4 (Android 5.0.1), Huawei Nexus 6P (Android 8.0), Google Pixel (Android 8.0) and it's reproducible on all devices, build 57 Beta and 58 Nightly. 
This is reproducible only if Custom tab is enabled and the link is opened through Custom Tab.
Prerequisites: enable Custom Tabs.
Flags: needinfo?(sorina.florean)
Assignee: nobody → nchen
tracking-fennec: ? → +
Priority: -- → P2
Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

https://reviewboard.mozilla.org/r/198816/#review204046
Attachment #8927493 - Flags: review?(cnevinchen) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca5529c5b232
Only try launching BrowserApp when handling notifications; r=nechen
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/964e27d56a7a
Backed out changeset ca5529c5b232 for mass failures on Android 4.3 API16+ debug. r=backout on a CLOSED TREE
Try run looks good [1]. I think the bustage was a glitch in the test harness.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c008922344e9c4fe9859f3faade15f75982adf03
Flags: needinfo?(nchen)
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26428c0d82a2
Only try launching BrowserApp when handling notifications; r=nechen
https://hg.mozilla.org/mozilla-central/rev/26428c0d82a2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

Request for 58

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Downloads started from a custom tab cannot be paused/cancelled.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small patch that only deals with this bug
[String changes made/needed]: None
Attachment #8927493 - Flags: approval-mozilla-beta?
Hi Sorina,
Can you help verify if this issue was fixed in the latest nightly?
Flags: needinfo?(sorina.florean)
Verifed as fixed on latest Nightly build (59.0a1 - 11/15).
Device: Google Pixel (Android 8.0) and Nexus 5 (Android 6.0.1).
Downloads started from a Custom tab can be paused/cancelled.
Flags: needinfo?(sorina.florean)
Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

Issue fixed and verified. Beta58+.
Attachment #8927493 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Target Milestone: Firefox 58 → Firefox 59
Verified as fixed on Beta 58.0b5 (2017-11-21).
Device: Samsung Galaxy Tab 3 (Android 7.0)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.