1411968 - Can't cancel/pause a download

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Custom Tabs, defect, P2)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Huawei Honor (Android 5.1.1), Oneplus Two (Android 6.0.1);
Build: 57.0b11;
Prerequisites: enable Custom Tabs.

Steps to reproduce:
1. Go to https://www.thinkbroadband.com/download;
2. Download 2,3 items;
3. Tap on "Cancel" from notification bar.

Expected result:
The download is canceled/paused.

Actual result:
The download is still working and message is displayed. See the screenshots.
- for OnePlus https://i.imgur.com/mLCU6Hw.png
- for Huawei https://i.imgur.com/f80TTA8.png

Comment 1

[Wesly Huang (EPM)]

It works with my Samsung S7 Edge (Android 7.0) & Pixel (Android 8.0) on 58 Nightly, 57 Beta, and 56 Release.

Would you help try few more device to know if this is some OEM specific? Thanks.

Comment 2

[Sorina Florean [:sflorean]]

Tested on Samsung Galaxy Tab 3 (Android 7.0), Samsung Galaxy Note 4 (Android 5.0.1), Huawei Nexus 6P (Android 8.0), Google Pixel (Android 8.0) and it's reproducible on all devices, build 57 Beta and 58 Nightly. 
This is reproducible only if Custom tab is enabled and the link is opened through Custom Tab.
Prerequisites: enable Custom Tabs.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1411968 - Only try launching BrowserApp when handling notifications;

Usually when we handle notification events, we try to launch whatever
Activity showed the notification so that the user can see results.
However, only BrowserApp supports being launched this way, so we should
restrict launching Activites to BrowserApp. For others like
CustomTabsActivity, we should just handle the notification event
directly. Currently, only download notifications are supported for these
other Activities, so it's okay if we don't display the Activity.

Review commit: https://reviewboard.mozilla.org/r/198816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198816/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

https://reviewboard.mozilla.org/r/198816/#review204046

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca5529c5b232
Only try launching BrowserApp when handling notifications; r=nechen

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for mass failures on Android 4.3 API16+ debug
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ca5529c5b2324352734feddb9c928192b8350a56&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

https://hg.mozilla.org/integration/autoland/rev/ca5529c5b2324352734feddb9c928192b8350a56

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/964e27d56a7a
Backed out changeset ca5529c5b232 for mass failures on Android 4.3 API16+ debug. r=backout on a CLOSED TREE

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Try run looks good [1]. I think the bustage was a glitch in the test harness.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c008922344e9c4fe9859f3faade15f75982adf03

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26428c0d82a2
Only try launching BrowserApp when handling notifications; r=nechen

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/26428c0d82a2

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

Request for 58

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Downloads started from a custom tab cannot be paused/cancelled.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small patch that only deals with this bug
[String changes made/needed]: None

Comment 12

[Gerry Chang [:gchang]]

Hi Sorina,
Can you help verify if this issue was fixed in the latest nightly?

Comment 13

[Sorina Florean [:sflorean]]

Verifed as fixed on latest Nightly build (59.0a1 - 11/15).
Device: Google Pixel (Android 8.0) and Nexus 5 (Android 6.0.1).
Downloads started from a Custom tab can be paused/cancelled.

Comment 14

[Gerry Chang [:gchang]]

Comment on attachment 8927493 [details]
Bug 1411968 - Only try launching BrowserApp when handling notifications;

Issue fixed and verified. Beta58+.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/66ecc5020b84

Comment 16

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Beta 58.0b5 (2017-11-21).
Device: Samsung Galaxy Tab 3 (Android 7.0)