Closed Bug 1411971 Opened 7 years ago Closed 7 years ago

[compare-locales] Return entry-based offsets in FluentChecker

Categories

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Product:
Localization Infrastructure and Tools
Component:
compare-locales
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stas, Assigned: stas)

References

Details

Attachments

(2 files)

Bug 1411971 - Part 1 - Rename Context.lines to Context.linecol.
59 bytes, text/x-review-board-request
Pike
: review+
Details
Bug 1411971 - Part 2 - Return entry-based offsets in FluentChecker.
59 bytes, text/x-review-board-request
Pike
: review+
Details
FluentChecker currently returns positions from the beginning of the file. This requires FluentEntity.position (and value_position) to have custom implementations. The migration module in python-fluent uses value_position to calculate the blame data for each entry. In particular it uses a negative offset to get the end position. Let's make FluentEntity.position less special by changing the values yielded from FluentChecker. This will allow us to use the default implementation from EnityBase.
Comment on attachment 8922328 [details] Bug 1411971 - Part 2 - Return entry-based offsets in FluentChecker. https://reviewboard.mozilla.org/r/193380/#review198660
Attachment #8922328 - Flags: review?(l10n) → review+
Comment on attachment 8922327 [details] Bug 1411971 - Part 1 - Rename Context.lines to Context.linecol. https://reviewboard.mozilla.org/r/193378/#review198662
Attachment #8922327 - Flags: review?(l10n) → review+
Assignee: nobody → stas
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: