1412112 - nsLayoutUtils::ViewIDForASR is relatively expensive

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

I profiled the new clipping code and 16.8% of the time in it is spent in nsINode::GetProperty(). I believe these mostly come from nsLayoutUtils::ViewIDForASR.

The clipping code is only about 10% of our WR display list building time now so fixing this is not urgent. But it's probably the first low hanging fruit in this area to look at when we get the chance.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4485835cc6a3f848212a10653dd59f2ae5496cd3

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1412112 - Cache the view id on the ASR to speed up the ViewIDForASR operation.

This also moves the function from nsLayoutUtils to be a function on the
ASR itself, which seems more appropriate.

Review commit: https://reviewboard.mozilla.org/r/202588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202588/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8931439 [details]
Bug 1412112 - Cache the view id on the ASR to speed up the ViewIDForASR operation.

https://reviewboard.mozilla.org/r/202588/#review207920

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5adba22ff86b
Cache the view id on the ASR to speed up the ViewIDForASR operation. r=mstange

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5adba22ff86b