Closed Bug 1412112 Opened 3 years ago Closed 2 years ago

nsLayoutUtils::ViewIDForASR is relatively expensive

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: jrmuizel, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(1 file)

I profiled the new clipping code and 16.8% of the time in it is spent in nsINode::GetProperty(). I believe these mostly come from nsLayoutUtils::ViewIDForASR.

The clipping code is only about 10% of our WR display list building time now so fixing this is not urgent. But it's probably the first low hanging fruit in this area to look at when we get the chance.
Whiteboard: [wr-mvp] [triage]
Whiteboard: [wr-mvp] [triage] → [wr-mvp][triage][gfx-noted]
Whiteboard: [wr-mvp][triage][gfx-noted] → [gfx-noted]
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Comment on attachment 8931439 [details]
Bug 1412112 - Cache the view id on the ASR to speed up the ViewIDForASR operation.

https://reviewboard.mozilla.org/r/202588/#review207920
Attachment #8931439 - Flags: review?(mstange) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5adba22ff86b
Cache the view id on the ASR to speed up the ViewIDForASR operation. r=mstange
https://hg.mozilla.org/mozilla-central/rev/5adba22ff86b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.