Closed Bug 1412112 Opened 3 years ago Closed 3 years ago
Layout Utils::View IDFor ASR is relatively expensive
59 bytes, text/x-review-board-request
I profiled the new clipping code and 16.8% of the time in it is spent in nsINode::GetProperty(). I believe these mostly come from nsLayoutUtils::ViewIDForASR. The clipping code is only about 10% of our WR display list building time now so fixing this is not urgent. But it's probably the first low hanging fruit in this area to look at when we get the chance.
Whiteboard: [wr-mvp] [triage] → [wr-mvp][triage][gfx-noted]
3 years ago
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Comment on attachment 8931439 [details] Bug 1412112 - Cache the view id on the ASR to speed up the ViewIDForASR operation. https://reviewboard.mozilla.org/r/202588/#review207920
Attachment #8931439 - Flags: review?(mstange) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5adba22ff86b Cache the view id on the ASR to speed up the ViewIDForASR operation. r=mstange
You need to log in before you can comment on or make changes to this bug.