1412188 - ChannelMediaResource shouldn't create new channels when closed

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Bug 1411504 changes CacheClientSeek() to create new channels asynchronously. It is possible for ChannelMediaResource::Close() to happen before Seek() which continues to create a new channel after Close() is called.

This renders ChannelMediaResource and MediaCacheStream in a bad state.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1412188 - ChannelMediaResource shouldn't create new channels when closed.

1. Add assertions to functions that shouldn't be called after Close().
2. Early return if closed from Suspend/Resume/Seek which are called asynchronously by the cache.

Review commit: https://reviewboard.mozilla.org/r/194470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194470/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8923287 [details]
Bug 1412188 - ChannelMediaResource shouldn't create new channels when closed.

https://reviewboard.mozilla.org/r/194470/#review199928

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eff1051ec941
ChannelMediaResource shouldn't create new channels when closed. r=gerald

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/eff1051ec941