1412217 - [Form Autofill] Insecure warning string should have end with a period

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P2)

Description

[Scott Wu [:scottwu]]

As pointed out here: https://bugzilla.mozilla.org/show_bug.cgi?id=1407530#c15

The insecure warning string should have a period at the end, as shown in the spec: https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/215537988

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1412217 - Add a period to the end of the insecure warning string.

Review commit: https://reviewboard.mozilla.org/r/193814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193814/

Comment 2

[Francesco Lodolo [:flod]]

Normally you'd need to change string ID when landing string changes. 
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Given the type of change, and the fact that we exposed strings only a few hours ago, I think we can avoid doing it this time.

Comment 3

[Scott Wu [:scottwu]]

I thought fixing punctuation falls into the category of not needing to change string ID, but I guess it's not relevant only in English. Thanks Francesco.

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8922678 [details]
Bug 1412217 - Add a period to the end of the insecure warning string.

https://reviewboard.mozilla.org/r/193814/#review198952

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4e5421dc197
Add a period to the end of the insecure warning string. r=lchang

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c4e5421dc197