Closed Bug 1412217 Opened 4 years ago Closed 4 years ago
[Form Autofill] Insecure warning string should have end with a period
59 bytes, text/x-review-board-request
As pointed out here: https://bugzilla.mozilla.org/show_bug.cgi?id=1407530#c15 The insecure warning string should have a period at the end, as shown in the spec: https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/215537988
Normally you'd need to change string ID when landing string changes. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings Given the type of change, and the fact that we exposed strings only a few hours ago, I think we can avoid doing it this time.
I thought fixing punctuation falls into the category of not needing to change string ID, but I guess it's not relevant only in English. Thanks Francesco.
Comment on attachment 8922678 [details] Bug 1412217 - Add a period to the end of the insecure warning string. https://reviewboard.mozilla.org/r/193814/#review198952
Attachment #8922678 - Flags: review?(lchang) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c4e5421dc197 Add a period to the end of the insecure warning string. r=lchang
You need to log in before you can comment on or make changes to this bug.