start_session calls wait_for_port and ignores the result

RESOLVED FIXED in Firefox 57

Status

Testing
Marionette
RESOLVED FIXED
29 days ago
23 days ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

58 Branch
mozilla58
Points:
---

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

29 days ago
Currently `start_session()` calls `wait_for_port()` in the case of Marionette doesn't manage the process. That is fine, but it actually doesn't take care of the result at all. It means that if a connection was not successful, the code would still continue in creating a TCPTransport client. This can fail with what I have seen on bug 1410366 comment 32.

https://dxr.mozilla.org/mozilla-central/rev/aa958b29c149a67fce772f8473e9586e71fbdb46/testing/marionette/client/marionette_driver/marionette.py#1225

I would propose that we make use of `raise_for_port()` here, so `start_session()` aborts early, and will not try to instantiate the client at all.
Comment hidden (mozreview-request)

Comment 2

28 days ago
mozreview-review
Comment on attachment 8922704 [details]
Bug 1412222 - start_session should not ignore the result of connection attempts.

https://reviewboard.mozilla.org/r/193834/#review199010
Attachment #8922704 - Flags: review?(ato) → review+

Comment 3

28 days ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a0ea908547d
start_session should not ignore the result of connection attempts. r=ato
https://hg.mozilla.org/mozilla-central/rev/8a0ea908547d
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
(Assignee)

Comment 5

23 days ago
To improve stability of the marionette client I would like to see this test only patch uplifted to beta. Thanks.
status-firefox57: --- → affected
Whiteboard: [checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/bd0f72296cf1
status-firefox57: affected → fixed
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.