|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Currently `start_session()` calls `wait_for_port()` in the case of Marionette doesn't manage the process. That is fine, but it actually doesn't take care of the result at all. It means that if a connection was not successful, the code would still continue in creating a TCPTransport client. This can fail with what I have seen on bug 1410366 comment 32. https://dxr.mozilla.org/mozilla-central/rev/aa958b29c149a67fce772f8473e9586e71fbdb46/testing/marionette/client/marionette_driver/marionette.py#1225 I would propose that we make use of `raise_for_port()` here, so `start_session()` aborts early, and will not try to instantiate the client at all.
Comment on attachment 8922704 [details] Bug 1412222 - start_session should not ignore the result of connection attempts. https://reviewboard.mozilla.org/r/193834/#review199010
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8a0ea908547d start_session should not ignore the result of connection attempts. r=ato
To improve stability of the marionette client I would like to see this test only patch uplifted to beta. Thanks.