1412222 - start_session calls wait_for_port and ignores the result

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Currently `start_session()` calls `wait_for_port()` in the case of Marionette doesn't manage the process. That is fine, but it actually doesn't take care of the result at all. It means that if a connection was not successful, the code would still continue in creating a TCPTransport client. This can fail with what I have seen on bug 1410366 comment 32.

https://dxr.mozilla.org/mozilla-central/rev/aa958b29c149a67fce772f8473e9586e71fbdb46/testing/marionette/client/marionette_driver/marionette.py#1225

I would propose that we make use of `raise_for_port()` here, so `start_session()` aborts early, and will not try to instantiate the client at all.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1412222 - start_session should not ignore the result of connection attempts.

By silently ignoring the result from 'wait_for_port' results in a
delayed socket error, which sometimes can cause strange results
as seen on bug 1410366.

Review commit: https://reviewboard.mozilla.org/r/193834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193834/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8922704 [details]
Bug 1412222 - start_session should not ignore the result of connection attempts.

https://reviewboard.mozilla.org/r/193834/#review199010

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0ea908547d
start_session should not ignore the result of connection attempts. r=ato

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8a0ea908547d

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To improve stability of the marionette client I would like to see this test only patch uplifted to beta. Thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bd0f72296cf1