Closed Bug 1412230 Opened 2 years ago Closed 2 years ago

[Form Autofill] Replace the word "Company" with "Organization"

Categories

(Toolkit :: Form Manager, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:V2])

Attachments

(1 file)

Although we have used the word "Company" for organization, after discussing with UX (:mark_liang), we felt it's better to just use "Organization", given that "Company" is a more restrictive term of "Organization".
If we were to make this change now, do you think a string ID change is still necessary?
Flags: needinfo?(francesco.lodolo)
(In reply to Scott Wu [:scottwu] from comment #1)
> If we were to make this change now, do you think a string ID change is still
> necessary?

Definitely yes. I expect languages to have different translations for those two words, and better to make sure they pick the right one.
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review198960

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:54
(Diff revision 2)
>  autocompleteFooterOptionOSXShort = Preferences
>  # LOCALIZATION NOTE (category.address, category.name, category.organization, category.tel, category.email):
>  # Used in autofill drop down suggestion to indicate what other categories Form Autofill will attempt to fill.
>  category.address = address
>  category.name = name
> -category.organization = company
> +category.organization = organization

Please use new string IDs.

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:103
(Diff revision 2)
>  addNewAddressTitle = Add New Address
>  editAddressTitle = Edit Address
>  givenName = First Name
>  additionalName = Middle Name
>  familyName = Last Name
> -organization = Company
> +organization = Organization

Same here, use a new string ID
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review199444

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:50
(Diff revisions 2 - 3)
>  # LOCALIZATION NOTE (autocompleteFooterOptionShort, autocompleteFooterOptionOSXShort): Used as a label for the button,
>  # displayed at the bottom of the drop down suggestion, to open Form Autofill browser preferences. This version is used
>  # instead of autocompleteFooterOption* when the menu width is below 185px.
>  autocompleteFooterOptionShort = More Options
>  autocompleteFooterOptionOSXShort = Preferences
>  # LOCALIZATION NOTE (category.address, category.name, category.organization, category.tel, category.email):

Nit: update the reference to category.organization2
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review199444

> Nit: update the reference to category.organization2

Good catch! thanks.
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review199448

Strings-wise it looks good, thanks.
Attachment #8922690 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review199458

::: browser/extensions/formautofill/content/formautofill.xml:200
(Diff revision 4)
>              // Show the categories in certain order to conform with the spec.
> -            let orderedCategoryList = ["address", "name", "organization", "tel", "email"];
> +            let orderedCategoryList = [{id: "address", string: "category.address"},

We should mention that `string` is used for L10N id. Maybe either change it to `l10nId` or comment it on the top.
Attachment #8922690 - Flags: review?(lchang) → review+
Comment on attachment 8922690 [details]
Bug 1412230 - Replace the word "Company" with "Organization".

https://reviewboard.mozilla.org/r/193838/#review199458

> We should mention that `string` is used for L10N id. Maybe either change it to `l10nId` or comment it on the top.

I changed `string` to `l10nId`. Think that would make it clear what it does.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e10c2f71fdcc
Replace the word "Company" with "Organization". r=flod,lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e10c2f71fdcc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.