1412232 - [Form Autofill] - Credit Cards synced between stations are not working properly

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect, P1)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: synccc.gif

[Environment:]
Windows 10x64, Ubuntu 14.04, Mac Os 10.12

Nightly 58.0a1 20171026221945
services.sync.engine.creditcards.available;true services.sync.engine.creditcards;true


[Steps:]


1. Open Firefox and login with Fx account
2. Save a few credit cards under Saved Credit Cards
3. Make sure credit card sync is enabled
4. Open another Fx on a different station( I tested sync between Mac 10.12, Windows 10 and Ubuntu 14.4) 
5. Login with the same Fx account
6. Trigger sync
7. Open Saved Credit Cards from Preferences
8. Verify the Show Credit Cards, Edit, Add, Cancel buttons and trigger autofill




[Actual Result:]
Credit Cards synced between stations are not displayed properly, on MacOS the credit card number is showed in full beside the hidden number
 - Credit card info is not displayed in EDIT mode
 - Autofill is not working for the synced credit cards (Windows 10x64 )
 - Cancel button from Edit mode is not working (all platforms)


[Expected Result:]
Sync credit cards should work properly on all platforms


[Note:]
This is a not regression

Comment 1

[Luke Chang [:lchang] (inactive)]

Hi Gabi,

Could you attach the "autofill-profiles.json" file under your profile folder of the Firefox with incorrect behaviors (assuming you didn't create any private data)? Thanks.

Comment 2

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: autofill-profiles.json

Added the autofill-profile json.

Comment 3

[Luke Chang [:lchang] (inactive)]

The json file looks normal.

The credit card data were encrypted so I can't reproduce the issue by applying the file directly. However, I notice that the reported symptom is exactly the same as what happened on my computer when I applied the file with undecryptable data. I suspect the cause is that somehow we can't decrypt the sync'ed records.


Hi Kit, 

Could you give us some clues? Thanks.

Comment 4

[Lina Butler [:lina]]

Hi Luke,

With your patch from bug 1395122, credit card syncing works fine for me. I can add a card on the first device, sync, see the card number on the second device, edit the card, and sync the changes back to the first. I suspect this is just because your patch didn't land in the Nightly 20171026221945 build; in earlier builds, I can reproduce the broken behavior that Gabi saw. I also suspect any credit cards that were synced before your patch landed won't work.

http://mcomella.xyz/is-it-in-nightly/ tells me that https://hg.mozilla.org/mozilla-central/rev/64adf2b4d017 isn't in today's Nightly, so it'll probably be in tomorrow's. Gabi, would you mind testing with a newer build next week?

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Re-verified credit card sync on the latest nightly 58.0a1 BUILD ID: 20171029220112, syncing works as expected between different platforms and between 2 browsers.
Testing was done on Windows 10x64, Ubuntu 14.4 and MacOS 10.12

Comment 6

[Lina Butler [:lina]]

Cool, thanks for following up!

Comment 7

[Luke Chang [:lchang] (inactive)]

Kit, Thanks for helping to investigate this.