Closed
Bug 141248
Opened 23 years ago
Closed 23 years ago
Implement keyboard charset for nsIPlatformCharset for Mac
Categories
(Core :: Internationalization, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.1beta
People
(Reporter: nhottanscp, Assigned: nhottanscp)
References
Details
(Keywords: intl)
Attachments
(1 file, 3 obsolete files)
1.60 KB,
patch
|
nhottanscp
:
review+
nhottanscp
:
superreview+
|
Details | Diff | Splinter Review |
nsIPlatformCharset provides a selector "kPlatformCharsetSel_KeyboardInput" which
is supposed to return a charset name based on the currently active keyboard script.
http://lxr.mozilla.org/seamonkey/source/intl/uconv/public/nsIPlatformCharset.h
Currenty, there is no implementation for "kPlatformCharsetSel_KeyboardInput".
http://lxr.mozilla.org/seamonkey/search?string=nsPlatformCharset%3A%3AGetCharset
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2alpha
QA -> yokoyama for the code implementation, feel free to reassign it back to IQA
in case you need IQA's help.
Keywords: intl
QA Contact: ruixu → yokoyama
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla1.2alpha → mozilla1.1beta
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Attachment #81918 -
Attachment is obsolete: true
Comment 4•23 years ago
|
||
Comment on attachment 81919 [details] [diff] [review]
change line breaks of the patch
r=ftang
please make sure you 0x00FFF & with the return value of
GetScriptManagerVariable(smKeyScript),
I remember there was some problem if I don't do that. CAnnot remember what is
broken without it.
Attachment #81919 -
Flags: review+
Assignee | ||
Comment 5•23 years ago
|
||
Attachment #81919 -
Attachment is obsolete: true
Assignee | ||
Comment 6•23 years ago
|
||
Comment on attachment 82095 [details] [diff] [review]
Changed to address ftang's comment.
copy 'r='
Attachment #82095 -
Flags: review+
Assignee | ||
Updated•23 years ago
|
Whiteboard: need 'sr'
Comment 7•23 years ago
|
||
Comment on attachment 82095 [details] [diff] [review]
Changed to address ftang's comment.
rs=brendan@mozilla.org if you:
- break the overlong line in the case kPlatformCharsetSel_KeyboardInput;
statement so it wraps nicely within 80 columns;
- put a break; after the default: case's statement, in case someone some day
adds a case at the end.
/be
Attachment #82095 -
Flags: superreview+
Assignee | ||
Comment 8•23 years ago
|
||
Attachment #82095 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Whiteboard: need 'sr'
Assignee | ||
Comment 9•23 years ago
|
||
Comment on attachment 84462 [details] [diff] [review]
Address super reviewer's comment.
copy 'r' and 'sr'
Attachment #84462 -
Flags: superreview+
Attachment #84462 -
Flags: review+
Assignee | ||
Comment 10•23 years ago
|
||
checked in to the trunk
I make this bug as Macintosh specific and open a separate XP bug.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
QA Contact: yokoyama → nhotta
Hardware: All → Macintosh
Resolution: --- → FIXED
Summary: Implement keyboard charset for nsIPlatformCharset → Implement keyboard charset for nsIPlatformCharset for Mac
Assignee | ||
Comment 11•23 years ago
|
||
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•