Closed Bug 1412504 Opened 3 years ago Closed 2 years ago

[dt-onboarding] Devtools onboarding page UI & UX polish followup

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Follow up to Bug 1408330.

See Bug 1408330 comment 16 and Bug 1408330 comment 17 from Victoria.
Summary: [dt-onboarding] Devtools onboarding page UI & UX polish → [dt-onboarding] Devtools onboarding page UI & UX polish followup
Adding leave-open in case we have more UI nits to implement.
Keywords: leave-open
Comment on attachment 8923757 [details]
Bug 1412504 - update otter image in about:devtools;

https://reviewboard.mozilla.org/r/194898/#review199952

Looks good

::: devtools/shim/aboutdevtools/images/otter.svg:1
(Diff revision 1)
> +<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 283 184"><defs><style>.cls-1{fill:#fff;}.cls-2{fill:none;}.cls-3{fill:#eaeaee;}.cls-4{fill:url(#linear-gradient);}.cls-5{fill:url(#New_Gradient_Swatch_1);}.cls-6{fill:url(#New_Gradient_Swatch_1-2);}.cls-7{fill:url(#New_Gradient_Swatch_1-3);}.cls-8{fill:url(#New_Gradient_Swatch_1-4);}.cls-9{fill:url(#New_Gradient_Swatch_1-5);}.cls-10{fill:url(#New_Gradient_Swatch_1-6);}.cls-11{fill:url(#New_Gradient_Swatch_1-7);}.cls-12{fill:url(#linear-gradient-2);}.cls-13{fill:url(#New_Gradient_Swatch_1-8);}.cls-14{fill:url(#linear-gradient-3);}.cls-15{fill:url(#linear-gradient-4);}.cls-16{fill:#00feff;}.cls-17{fill:url(#linear-gradient-5);}.cls-18{fill:url(#New_Gradient_Swatch_1-9);}</style><linearGradient id="linear-gradient" x1="41.48" y1="25.02" x2="220.85" y2="204.38" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#ccfbff"/><stop offset="1" stop-color="#c9e4ff"/></linearGradient><linearGradient id="New_Gradient_Swatch_1" x1="28.89" y1="8.61" x2="232.86" y2="212.57" gradientUnits="userSpaceOnUse"><stop offset="0" stop-color="#00c8d7"/><stop offset="1" stop-color="#0a84ff"/></linearGradient><linearGradient id="New_Gradient_Swatch_1-2" x1="28.33" y1="9.17" x2="232.3" y2="213.13" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="New_Gradient_Swatch_1-3" x1="21.57" y1="15.93" x2="225.54" y2="219.89" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="New_Gradient_Swatch_1-4" x1="42.38" y1="-4.88" x2="246.34" y2="199.09" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="New_Gradient_Swatch_1-5" x1="20.17" y1="17.33" x2="224.13" y2="221.3" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="New_Gradient_Swatch_1-6" x1="41.18" y1="-3.68" x2="245.14" y2="200.29" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="New_Gradient_Swatch_1-7" x1="13.58" y1="23.92" x2="217.55" y2="227.88" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="linear-gradient-2" x1="76.52" y1="-10.02" x2="255.88" y2="169.35" xlink:href="#linear-gradient"/><linearGradient id="New_Gradient_Swatch_1-8" x1="62.22" y1="-24.72" x2="266.19" y2="179.24" xlink:href="#New_Gradient_Swatch_1"/><linearGradient id="linear-gradient-3" x1="73.09" y1="-6.59" x2="252.46" y2="172.78" xlink:href="#linear-gradient"/><linearGradient id="linear-gradient-4" x1="60.49" y1="6.01" x2="239.85" y2="185.38" xlink:href="#linear-gradient"/><linearGradient id="linear-gradient-5" x1="68.95" y1="-2.45" x2="248.31" y2="176.92" xlink:href="#linear-gradient"/><linearGradient id="New_Gradient_Swatch_1-9" x1="31.51" y1="5.99" x2="235.48" y2="209.95" xlink:href="#New_Gradient_Swatch_1"/></defs><title>Asset 6</title><g id="Layer_2" data-name="Layer 2"><g id="Layer_1-2" data-name="Layer 1"><ellipse class="cls-1" cx="169.02" cy="97.23" rx="8.56" ry="10.44"/><path class="cls-2" d="M161,110.89c.12-.18.23-.36.36-.54l-.69.3Z"/><path class="cls-3" d="M57.62,92.12a17.9,17.9,0,0,0-8.89,2.64,16.12,16.12,0,0,1-8.89,2.41,16.11,16.11,0,0,1-8.89-2.41A18,18,0,0,0,21.1,92.1a18,18,0,0,0-9.84,2.65,16.11,16.11,0,0,1-8.89,2.41,1,1,0,1,0,0,2,18,18,0,0,0,9.84-2.65A16.11,16.11,0,0,1,21.1,94.1,16.11,16.11,0,0,1,30,96.51a18,18,0,0,0,9.84,2.65,18,18,0,0,0,9.84-2.65,16.11,16.11,0,0,1,8.89-2.41h.38c0-.13,0-.26,0-.38A15.72,15.72,0,0,1,57.62,92.12Z"/><path class="cls-3" d="M46.37,90.34a.5.5,0,0,0,.2,0l.92-.44A.5.5,0,0,0,47,89l-.88.42a.5.5,0,0,0,.2,1Z"/><path class="cls-3" d="M20.51,86.67a16.52,16.52,0,0,1,9.13,2.47c.63.34,1.27.69,1.95,1a.5.5,0,0,0,.21,0,.5.5,0,0,0,.21-1c-.66-.31-1.28-.65-1.9-1a17.58,17.58,0,0,0-9.6-2.59.5.5,0,0,0,0,1Z"/><path class="cls-3" d="M39.56,90.74a.5.5,0,0,0,0,1h0a20.35,20.35,0,0,0,3.06-.26.5.5,0,1,0-.16-1A19.34,19.34,0,0,1,39.56,90.74Z"/><path class="cls-3" d="M58.41,99.85a.5.5,0,1,0,0,1c.69,0,1.31,0,1.9.09a4,4,0,0,1-.69-1C59.22,99.87,58.84,99.85,58.41,99.85Z"/><path class="cls-3" d="M205.64,113.6a18,18,0,0,0-9.84,2.65,16.11,16.11,0,0,1-8.89,2.41,1,1,0,0,0,0,2,18,18,0,0,0,9.84-2.65,16.11,16.11,0,0,1,8.8-2.41c.14-.68.29-1.35.46-2Z"/><path class="cls-3" d="M280.56,113.6a18,18,0,0,0-9.84,2.65,17.58,17.58,0,0,1-17.78,0,18,18,0,0,0-9.84-2.65,17.32,17.32,0,0,0-8.05,1.72c.16.68.31,1.36.44,2a15.37,15.37,0,0,1,7.61-1.74A16.11,16.11,0,0,1,252,118a19.56,19.56,0,0,0,19.68,0,16.11,16.11,0,0,1,8.89-2.41,1,1,0,0,0,0-2Z"/><path class="cls-3" d="M240.11,107.3a.5.5,0,0,0,.05,1h.05a21.53,21.53,0,0,1,2.28-.12.5.5,0,0,0,0-1A22.53,22.53,0,0,0,240.11,107.3Z"/><path class="cls-3" d="M205,107.17a.5.5,0,0,0,0,1,20.45,20.45,0,0,1,2.77.18c.14-.34.28-.65.42-1A21.17,21.17,0,0,0,205,107.17Z"/><path class="cls-3" d="M254.45,124.92c-.66-.31-1.28-.65-1.9-1a17.58,17.58,0,0,0-9.6-2.59.5.5,0,0,0,0,1,16.53,16.53,0,0,1,9.13,2.47c.63.34,1.27.69,1.95,1a.5.5,0,0,0,.21,0,.5.5,0,0,0,.21-1Z"/><path class="cls-3" d="M280.39,121.35a22.35,22.35,0,0,0-2.37.12.5.5,0,0,0,.05,1h.05a19.28,19.28,0,0,1,2.28-.11.5.5,0,1,0,0-1Z"/><path class="cls-3" d="M269.49,124.64l-.88.42a.5.5,0,0,0,.41.91l.92-.44a.5.5,0,1,0-.45-.89Z"/><path class="cls-3" d="M264.91,126.17a19.34,19.34,0,0,1-2.91.24.5.5,0,0,0,0,1h0a20.35,20.35,0,0,0,3.06-.26.5.5,0,1,0-.16-1Z"/><path class="cls-3" d="M75.17,131.86A32.14,32.14,0,0,1,69,110.77c-11.76,4-19.15,9.74-19.15,16.15,0,12,26,21.75,58,21.75q2.81,0,5.56-.1c-.76-.44-1.5-.89-2.2-1.35C95.78,147.66,82.69,142.13,75.17,131.86Z"/><path class="cls-3" d="M157.22,167.25a18,18,0,0,0-9.84,2.65,17.58,17.58,0,0,1-17.78,0,19.56,19.56,0,0,0-19.68,0,17.58,17.58,0,0,1-17.78,0,18,18,0,0,0-9.84-2.65,18,18,0,0,0-9.84,2.65,16.11,16.11,0,0,1-8.89,2.41,1,1,0,1,0,0,2,18,18,0,0,0,9.84-2.65,17.57,17.57,0,0,1,17.78,0,19.57,19.57,0,0,0,19.68,0,17.58,17.58,0,0,1,17.78,0,19.56,19.56,0,0,0,19.68,0,16.11,16.11,0,0,1,8.89-2.41,1,1,0,0,0,0-2Z"/><path class="cls-3" d="M116.88,161.94a21.53,21.53,0,0,1,2.28-.12.5.5,0,0,0,0-1,22.53,22.53,0,0,0-2.39.12.5.5,0,0,0,.05,1Z"/><path class="cls-3" d="M107.56,165.5a.5.5,0,0,0,.2,0l.92-.44a.5.5,0,1,0-.45-.89l-.88.42a.5.5,0,0,0,.2,1Z"/><path class="cls-3" d="M100.77,166.9a20.35,20.35,0,0,0,3.06-.26.5.5,0,1,0-.16-1,19.34,19.34,0,0,1-2.91.24.5.5,0,0,0,0,1Z"/><path class="cls-3" d="M90.83,164.3c.63.34,1.27.69,1.95,1a.5.5,0,0,0,.21,0,.5.5,0,0,0,.21-1c-.66-.31-1.28-.65-1.9-1a17.58,17.58,0,0,0-9.6-2.59.5.5,0,0,0,0,1A16.52,16.52,0,0,1,90.83,164.3Z"/><path class="cls-3" d="M141.57,179.83a19.34,19.34,0,0,1-2.91.24.5.5,0,0,0,0,1h0a20.35,20.35,0,0,0,3.06-.26.5.5,0,1,0-.16-1Z"/><path class="cls-3" d="M131.11,178.58c-.66-.31-1.28-.65-1.9-1a17.58,17.58,0,0,0-9.6-2.59.5.5,0,1,0,0,1,16.53,16.53,0,0,1,9.13,2.47c.63.34,1.27.69,1.95,1a.5.5,0,0,0,.21,0,.5.5,0,0,0,.21-1Z"/><path class="cls-3" d="M146.15,178.3l-.88.42a.5.5,0,0,0,.41.91l.92-.44a.5.5,0,1,0-.45-.89Z"/><path class="cls-3" d="M157,175a22.35,22.35,0,0,0-2.37.12.5.5,0,0,0,.05,1h.05a19.28,19.28,0,0,1,2.28-.11.5.5,0,1,0,0-1Z"/><path class="cls-1" d="M160.6,111.54c.12-.22.26-.43.39-.64l-.33-.24.69-.3a10.15,10.15,0,0,1,2.29-2.29l-.65-2.15c-2.47,2-6.69,3.12-9.78,3.69a39.81,39.81,0,0,1,6.55,4A10.23,10.23,0,0,1,160.6,111.54Z"/><path class="cls-1" d="M167.92,116.92h0a1,1,0,0,0-.68,1.28l1,3.42c5.22,6,10.75,14.51,15.51,26.68a1,1,0,0,1-.4,1.21c-8.92,5.6-19.08,7.25-27.94,7.25a77.84,77.84,0,0,1-10-.67c-12.25-1.6-24.68-6-33.34-11.91-14.84.68-27.38-4.43-34.46-14.1-5.54-7.57-7-17-4.33-26.77a6,6,0,0,1-4.14,1.09,1,1,0,0,1-.7-.43,6.6,6.6,0,0,1-1.29-5.56,35.1,35.1,0,0,1-3.81.83,1,1,0,0,1-1-.71,10.92,10.92,0,0,1-.17-5.39c0-.22.08-.43.1-.61-1.81-1.3-5.63-5.48-5.88-13.55a11.29,11.29,0,0,1-7.73-6.6,6.72,6.72,0,0,1,.94-6.84C53.28,60.89,59.77,63,62,63.93c1.76-2.25,8.17-9.37,20.8-12.84a4.26,4.26,0,0,1-1-.92,3.6,3.6,0,0,1-.73-2.67,1,1,0,0,1,.68-.78c.32-.1,6.38-2,10.73.22a17.78,17.78,0,0,1-.18-2.77,1,1,0,0,1,1-1c3.78,0,6,1.49,8.19,3.92h.79A35.87,35.87,0,0,1,121,51.85c1.42-2,5.49-6.65,11-4.78a6.72,6.72,0,0,1,4.48,5.26,11.3,11.3,0,0,1-3,9.81,27.88,27.88,0,0,1,2.32,7.4c.87,5.44-.28,10.12-3.33,13.65,1.77,1.21,1.84,2.38,1.69,3A2.53,2.53,0,0,1,132,88c2.46,3.55,6.63,6.18,11.92,7.48,6.59,1.63,12.74.75,15.6-1l-.88-2.92a4,4,0,0,0-.53.27c-2.17,1.45-7.8,2.11-13.47.71a19.57,19.57,0,0,1-8.27-4.12A5.09,5.09,0,0,0,137,86.9a5.16,5.16,0,0,0-.69-4c2.41-3.86,3.23-8.58,2.38-13.87a31,31,0,0,0-1.8-6.43,14.26,14.26,0,0,0,2.5-10.91,9.74,9.74,0,0,0-6.45-7.5c-5.37-1.82-9.88.84-12.75,3.85a37.61,37.61,0,0,0-17.41-4,12.67,12.67,0,0,0-9.48-3.93A4,4,0,0,0,89.51,43a20.93,20.93,0,0,0-8.66.87A4,4,0,0,0,78.14,47a6.25,6.25,0,0,0,.09,2.41,43.55,43.55,0,0,0-17.14,11C56.81,59.14,51,59,47.21,63.67a9.74,9.74,0,0,0-1.4,9.79,14.22,14.22,0,0,0,7.68,7.72,22,22,0,0,0,4.12,10.94A15.72,15.72,0,0,0,59,93.73c0,.12,0,.25,0,.38a13.07,13.07,0,0,0,.47,5.28,4.3,4.3,0,0,0,.89,1.55,4,4,0,0,0,3.25,1.3c.19,0,.44,0,.72-.1A11.51,11.51,0,0,0,66,105.68a4,4,0,0,0,2.78,1.7l.59.06q-.24,1.68-.34,3.33a32.14,32.14,0,0,0,6.18,21.09c7.53,10.27,20.62,15.81,36,15.36.7.45,1.44.9,2.2,1.35a87.71,87.71,0,0,0,42.06,11.21c10.35,0,20.7-2.19,29.51-7.72a4,4,0,0,0,1.6-4.85C180.91,132.77,174.1,123.21,167.92,116.92Z"/><path class="cls-4" d="M159.84,119.3a10.16,10.16,0,0,1-.43-3.28c-5.91-4.68-10.23-5.86-10.32-5.88a1,1,0,0,1-.4-.23,31.8,31.8,0,0,0-8.85-1.74.5.5,0,0,1,0-1,32.52,32.52,0,0,1,8.59,1.61,1,1,0,0,1,.82-.6c2.81-.26,10.35-1.5,13-4.22l-2.44-7.31c-3.9,1.9-10.35,2.24-16.32.77-6.46-1.59-11.43-5.06-14-9.76a1,1,0,0,1,.88-1.48c1.31,0,1.79-.35,1.84-.44s-.32-.69-1.79-1.42a1,1,0,0,1-.25-1.61c7.87-7.63,1.38-19.93,1.32-20.06a1,1,0,0,1-.08-.2l-.08-.27a1,1,0,0,1,.29-1,9.39,9.39,0,0,0,2.94-8.42A4.77,4.77,0,0,0,131.37,49c-5.22-1.77-9.14,4.65-9.18,4.72a1,1,0,0,1-.16.18,23.55,23.55,0,0,1,3.15,2.46.5.5,0,0,1-.71.71,32.66,32.66,0,0,0-6.33-4.39,33.14,33.14,0,0,0-15.86-3.54l-1.25,0a1,1,0,0,1-.73-.34c-1.81-2.06-3.37-3.28-6-3.52a10.06,10.06,0,0,0,1.27,4.72,1,1,0,0,1-1.75,1h0c-2.32-4.12-8.57-3-10.73-2.49a1.77,1.77,0,0,0,.3.57,4.55,4.55,0,0,0,3.15,1.26,1,1,0,0,1,.1,2c-12.52,2.52-19.56,8.94-22.25,11.93a.49.49,0,0,1-.16.39,11.88,11.88,0,0,0-1.13,1.18h0a21,21,0,0,0-3.83,8,.5.5,0,0,1-.49.4h-.1a.5.5,0,0,1-.39-.59A22.21,22.21,0,0,1,61.69,66c-1.13-.51-7.44-3.11-10.58.82a4.77,4.77,0,0,0-.63,4.88,9.39,9.39,0,0,0,7,5.51,1,1,0,0,1,.84,1c0,8.62,4.46,12.52,5.34,12.93a1,1,0,0,1,.57.83,6.55,6.55,0,0,1-.16,1.57A9.36,9.36,0,0,0,64,97.11c1.28-.27,3.54-.85,5-1.24a1,1,0,0,1,.89,1.75c-.2.17-1.94,1.77-.06,4.84,2.42,0,4.34-2.74,4.36-2.76a1,1,0,0,1,.58-.41l.33-.08a1,1,0,0,1,1.18,1.32c-3.9,10.4-2.86,20.48,2.93,28.38,6.73,9.18,18.79,14,33.08,13.26h.05a1,1,0,0,1,.57.18c15.46,10.63,47.72,18.45,68.69,5.91a90.43,90.43,0,0,0-12.39-22.2.49.49,0,0,1-.23.08.53.53,0,0,1,0,.07.51.51,0,0,1-.3.25.5.5,0,0,1-.2,0A10.19,10.19,0,0,1,159.84,119.3Zm12.5,20.87c1.15,3.83-4,8.55-16,8-22-1-31.32-6.9-35-9a72.42,72.42,0,0,1-12-8.12,11.59,11.59,0,0,0,0,3.92,1,1,0,0,1-.78,1.18l-.2,0a1,1,0,0,1-1-.8A14.91,14.91,0,0,1,111,123.07c1.82-1.86,5.13-3.87,10.49-2.89l.1,0h0a.5.5,0,0,1,.67.22,8.67,8.67,0,0,0,6.16,4.61,2.16,2.16,0,0,0,2-.68c2.71-3.61-.8-7.2-1-7.35-4.83-4.08-14.1-6.58-25.56-1.27-6.33,2.94-10.59,7.32-10.59,10.92a.5.5,0,0,1-1,0c0-2.67,1.92-5.6,5.18-8.19-4.81-6.57-8.65-12.38-7.18-15.31,0,0,7.5,1.5,18.5-3,5.51-2.25,8.64-6.77,10.34-9.85a43.49,43.49,0,0,1-16.79,7.14c-17.5,3.53-33.64-3.29-36-15.23s9.82-24.49,27.32-28,33.64,3.29,36,15.23c1.38,6.82-2,13.83-8.45,19.25,1.26,4.25,5.16,16.21,10.07,19.48,6,4,9,3,18,6S169.33,130.17,172.33,140.17Z"/><path class="cls-5" d="M143.93,95.46c-5.28-1.3-9.45-3.93-11.92-7.48a2.53,2.53,0,0,0,2.1-1.78c.15-.64.08-1.8-1.69-3,3.05-3.52,4.21-8.21,3.33-13.65a27.88,27.88,0,0,0-2.32-7.4,11.3,11.3,0,0,0,3-9.81A6.72,6.72,0,0,0,132,47.07c-5.51-1.87-9.58,2.81-11,4.78a35.87,35.87,0,0,0-18.7-4.76h-.79c-2.21-2.43-4.41-3.92-8.19-3.92a1,1,0,0,0-1,1,17.78,17.78,0,0,0,.18,2.77c-4.36-2.23-10.41-.32-10.73-.22a1,1,0,0,0-.68.78,3.6,3.6,0,0,0,.73,2.67,4.26,4.26,0,0,0,1,.92c-12.63,3.47-19,10.6-20.8,12.84-2.24-.92-8.73-3-12.46,1.62a6.72,6.72,0,0,0-.94,6.84A11.29,11.29,0,0,0,56.35,79c.24,8.08,4.06,12.25,5.88,13.55,0,.18-.06.39-.1.61a10.92,10.92,0,0,0,.17,5.39,1,1,0,0,0,1,.71,35.1,35.1,0,0,0,3.81-.83A6.6,6.6,0,0,0,68.43,104a1,1,0,0,0,.7.43,6,6,0,0,0,4.14-1.09c-2.71,9.8-1.21,19.2,4.33,26.77,7.08,9.66,19.62,14.77,34.46,14.1,8.67,5.87,21.1,10.32,33.34,11.91a77.84,77.84,0,0,0,10,.67c8.86,0,19-1.65,27.94-7.25a1,1,0,0,0,.4-1.21c-4.76-12.17-10.3-20.71-15.51-26.68l-1-3.42a1,1,0,0,1,.68-1.28h0l4.47-1.36a1.51,1.51,0,0,1,.68.86l2.26,7.47a.51.51,0,0,0,.64.34c.06,0,.11-.08.18-.1a2.2,2.2,0,0,0,1.09-.52.48.48,0,0,0,.29-.15,10.73,10.73,0,0,0,1.47-2.09,10.69,10.69,0,0,0-8.62-15.7l-.16-.52h.1a1,1,0,0,0,.5-.13c4.54-2.59,5.18-8.55,2.92-12.49a6.09,6.09,0,0,0-3.23-2.86,5.59,5.59,0,0,0-4.69.62,1,1,0,0,0-.13.12l-.54-1.77a10.76,10.76,0,0,0,2.9-3.43,10.69,10.69,0,0,0-6.77-15.39.48.48,0,0,0-.22,0c-.33,0-.45.07-.86,0a5.46,5.46,0,0,0-.65.22.51.51,0,0,0-.34.64l2.26,7.47a1.51,1.51,0,0,1-.09,1.1l-4.5,1.36a1,1,0,0,1-1.28-.68l-2.21-7.28a.47.47,0,0,0-.71-.28.49.49,0,0,0-.65,0,10.2,10.2,0,0,0,6.22,18l.36,1.2.88,2.92C156.67,96.21,150.52,97.09,143.93,95.46Zm24.53,31a.5.5,0,0,0,.2,0,.51.51,0,0,0,.3-.25.53.53,0,0,0,0-.07.49.49,0,0,0,.23-.08,90.43,90.43,0,0,1,12.39,22.2c-21,12.54-53.23,4.72-68.69-5.91a1,1,0,0,0-.57-.18h-.05c-14.29.76-26.35-4.08-33.08-13.26-5.79-7.9-6.83-18-2.93-28.38a1,1,0,0,0-1.18-1.32l-.33.08a1,1,0,0,0-.58.41s-1.94,2.75-4.36,2.76c-1.88-3.07-.14-4.67.06-4.84A1,1,0,0,0,69,95.87c-1.44.39-3.71,1-5,1.24a9.36,9.36,0,0,1,.09-3.62,6.55,6.55,0,0,0,.16-1.57,1,1,0,0,0-.57-.83c-.88-.41-5.34-4.3-5.34-12.93a1,1,0,0,0-.84-1,9.39,9.39,0,0,1-7-5.51,4.77,4.77,0,0,1,.63-4.88c3.14-3.93,9.45-1.33,10.58-.82a22.21,22.21,0,0,0-3.35,7.59.5.5,0,0,0,.39.59h.1a.5.5,0,0,0,.49-.4,21,21,0,0,1,3.83-8h0a11.88,11.88,0,0,1,1.13-1.18.49.49,0,0,0,.16-.39c2.69-3,9.72-9.42,22.25-11.93a1,1,0,0,0-.1-2A4.55,4.55,0,0,1,83.45,49a1.77,1.77,0,0,1-.3-.57c2.17-.53,8.42-1.64,10.73,2.49h0a1,1,0,0,0,1.75-1,10.06,10.06,0,0,1-1.27-4.72c2.59.25,4.15,1.47,6,3.52a1,1,0,0,0,.73.34l1.25,0a33.14,33.14,0,0,1,15.86,3.54A32.66,32.66,0,0,1,124.48,57a.5.5,0,0,0,.71-.71A23.55,23.55,0,0,0,122,53.85a1,1,0,0,0,.16-.18c0-.07,4-6.49,9.18-4.72a4.77,4.77,0,0,1,3.16,3.77,9.39,9.39,0,0,1-2.94,8.42,1,1,0,0,0-.29,1l.08.27a1,1,0,0,0,.08.2c.07.12,6.55,12.42-1.32,20.06a1,1,0,0,0,.25,1.61c1.46.73,1.77,1.33,1.79,1.42s-.53.44-1.84.44a1,1,0,0,0-.88,1.48c2.56,4.7,7.53,8.17,14,9.76,6,1.47,12.42,1.13,16.32-.77l2.44,7.31c-2.61,2.72-10.16,4-13,4.22a1,1,0,0,0-.82.6,32.52,32.52,0,0,0-8.59-1.61.5.5,0,0,0,0,1,31.8,31.8,0,0,1,8.85,1.74,1,1,0,0,0,.4.23c.09,0,4.41,1.2,10.32,5.88a10.17,10.17,0,0,0,9,10.45ZM163,105.92l.65,2.15a10.15,10.15,0,0,0-2.29,2.29c-.13.17-.24.35-.36.54s-.27.42-.39.64a10.23,10.23,0,0,0-.84,2.12,39.81,39.81,0,0,0-6.55-4C156.3,109,160.52,107.92,163,105.92Zm15.87,7.61a9.62,9.62,0,0,1-.73,7.38,9.29,9.29,0,0,1-.76,1.18l-1.94-6.39a2,2,0,0,0-2.52-1.35L167.61,116a2,2,0,0,0-1.35,2.52l1.94,6.39a9.69,9.69,0,0,1-5.26-13.68,9.75,9.75,0,0,1,2.89-3.3.5.5,0,0,0,.19-.55l-1.36-4.48a12.91,12.91,0,0,0,4.3,1.49l.6,1.94a.5.5,0,0,0,.46.35A9.68,9.68,0,0,1,178.86,113.53ZM167.33,91.8a3.38,3.38,0,0,1,2.54-.22,4.13,4.13,0,0,1,2.15,2c1.31,2.3,1.54,6.41-1,8.84a1,1,0,0,0-.54,0c-.77.26-3.62-.25-5.79-1.81a3.92,3.92,0,0,1-1.9-2.91C162.83,94.65,166.56,92.26,167.33,91.8Zm-8.4-11.25.3-.09-.3.09Zm-7.69,1.87A9.63,9.63,0,0,1,152,75a9.35,9.35,0,0,1,.76-1.18l1.94,6.39a2,2,0,0,0,2.52,1.35L162.5,80a2,2,0,0,0,1.35-2.52l-1.94-6.39a9.69,9.69,0,0,1,5.26,13.68,9.73,9.73,0,0,1-2.89,3.3.5.5,0,0,0-.19.55l.76,2.46a12.5,12.5,0,0,0-2.87,3l-1.34-4.43a.5.5,0,0,0-.46-.36A9.67,9.67,0,0,1,151.24,82.42Z"/><path class="cls-6" d="M113.57,84.2a1,1,0,0,0-1.21.73,4.38,4.38,0,0,1-1.89,2.63,3.1,3.1,0,0,1-2.69-.29,1,1,0,0,0-1.37.52,3.23,3.23,0,0,1-1.86,2,5.3,5.3,0,0,1-3.72-.54,1,1,0,0,0-1,1.74,8.2,8.2,0,0,0,3.64,1,5.17,5.17,0,0,0,1.71-.28,4.85,4.85,0,0,0,2.63-2.27,4.56,4.56,0,0,0,3.5-.08c2.25-1,3-3.85,3-4A1,1,0,0,0,113.57,84.2Z"/><path class="cls-7" d="M82.14,79.68A1.5,1.5,0,1,0,85,78.62s-.6-1.59-1.46-3.94a1.5,1.5,0,0,0-2.82,1C81.54,78.08,82.14,79.68,82.14,79.68Z"/><path class="cls-8" d="M115,70.74a1.5,1.5,0,0,0,1.43,1.05,1.48,1.48,0,0,0,.45-.07,1.5,1.5,0,0,0,1-1.88l-1.05-3.37a1.5,1.5,0,0,0-2.86.89Z"/><path class="cls-9" d="M87.91,79.35a1,1,0,0,0-1.14.83,2.9,2.9,0,0,1-1.29,2.27,4.74,4.74,0,0,1-3.58-.12,1,1,0,0,0-.79,1.84,8.22,8.22,0,0,0,3,.6,4.87,4.87,0,0,0,2.37-.56,4.8,4.8,0,0,0,2.31-3.71A1,1,0,0,0,87.91,79.35Z"/><path class="cls-10" d="M121.16,70.69a1,1,0,0,0-1.22.71,2.9,2.9,0,0,1-1.52,2.13,4.74,4.74,0,0,1-3.55-.48,1,1,0,0,0-1,1.75,8,8,0,0,0,3.49.92,4.61,4.61,0,0,0,1.81-.35,4.81,4.81,0,0,0,2.68-3.46A1,1,0,0,0,121.16,70.69Z"/><path class="cls-1" d="M149.33,114.17c-9-3-12-2-18-6-4.91-3.27-8.81-15.23-10.07-19.48,6.42-5.42,9.82-12.43,8.45-19.25-2.41-11.94-18.55-18.76-36-15.23s-29.73,16.07-27.32,28,18.55,18.76,36,15.23a43.49,43.49,0,0,0,16.79-7.14c-1.7,3.08-4.83,7.6-10.34,9.85-11,4.5-18.5,3-18.5,3-1.47,2.93,2.37,8.74,7.18,15.31a29.76,29.76,0,0,1,6-3.64c7.79-3.61,18.89-5.13,26.66,1.44.07.07,4.3,4.38,1.08,8.68a3.08,3.08,0,0,1-2.88,1.08,9.48,9.48,0,0,1-6.36-4.14,1,1,0,0,1-.83.24c-3.62-.66-6.55.13-8.71,2.32a12.2,12.2,0,0,0-3.1,6.57,72.42,72.42,0,0,0,12,8.12c3.68,2.1,13,8,35,9,12,.55,17.15-4.17,16-8C169.33,130.17,158.33,117.17,149.33,114.17ZM81.57,73.78a1.5,1.5,0,0,1,1.92.89c.86,2.35,1.46,3.94,1.46,3.94a1.5,1.5,0,0,1-2.81,1.05s-.6-1.6-1.47-4A1.5,1.5,0,0,1,81.57,73.78ZM86.43,84.2a4.87,4.87,0,0,1-2.37.56,8.22,8.22,0,0,1-3-.6,1,1,0,0,1,.79-1.84,4.74,4.74,0,0,0,3.58.12,2.9,2.9,0,0,0,1.29-2.27,1,1,0,0,1,2,.31A4.8,4.8,0,0,1,86.43,84.2Zm28.46-18.72a1.5,1.5,0,0,1,1.88,1l1.05,3.37a1.5,1.5,0,0,1-1,1.88,1.48,1.48,0,0,1-.45.07A1.5,1.5,0,0,1,115,70.74l-1.05-3.37A1.5,1.5,0,0,1,114.89,65.49ZM97.76,83.11A2,2,0,0,1,98,80.87c3.34-4,11-5.84,13.58-5.26a2,2,0,0,1,1.58,1.33,3.89,3.89,0,0,1-.36,3A16.76,16.76,0,0,1,108.06,85a6.81,6.81,0,0,1-2,1.12,1.56,1.56,0,0,1-.34,0,6.39,6.39,0,0,1-.72,0C102.87,85.9,98.57,84.72,97.76,83.11Zm16.55,2.29c0,.12-.73,2.92-3,4a4.56,4.56,0,0,1-3.5.08,4.85,4.85,0,0,1-2.63,2.27,5.17,5.17,0,0,1-1.71.28,8.2,8.2,0,0,1-3.64-1,1,1,0,0,1,1-1.74,5.3,5.3,0,0,0,3.72.54,3.23,3.23,0,0,0,1.86-2,1,1,0,0,1,1.37-.52,3.1,3.1,0,0,0,2.69.29,4.38,4.38,0,0,0,1.89-2.63,1,1,0,0,1,1.94.47Zm4.9-10a4.61,4.61,0,0,1-1.81.35,8,8,0,0,1-3.49-.92,1,1,0,0,1,1-1.75,4.74,4.74,0,0,0,3.55.48,2.9,2.9,0,0,0,1.52-2.13,1,1,0,0,1,1.93.51A4.81,4.81,0,0,1,119.2,75.38Z"/><path class="cls-11" d="M121.15,122.15a1,1,0,0,0,.83-.24,9.48,9.48,0,0,0,6.36,4.14,3.08,3.08,0,0,0,2.88-1.08c3.22-4.3-1-8.61-1.08-8.68-7.77-6.58-18.86-5.06-26.66-1.44a29.76,29.76,0,0,0-6,3.64c-3.26,2.59-5.18,5.52-5.18,8.19a.5.5,0,0,0,1,0c0-3.59,4.25-8,10.59-10.92,11.46-5.31,20.73-2.81,25.56,1.27.15.15,3.66,3.74,1,7.35a2.16,2.16,0,0,1-2,.68,8.67,8.67,0,0,1-6.16-4.61.5.5,0,0,0-.67-.22h0l-.1,0c-5.36-1-8.67,1-10.49,2.89a14.91,14.91,0,0,0-3.67,12.29,1,1,0,0,0,1,.8l.2,0a1,1,0,0,0,.78-1.18,11.59,11.59,0,0,1,0-3.92,12.2,12.2,0,0,1,3.1-6.57C114.61,122.28,117.54,121.49,121.15,122.15Z"/><path class="cls-1" d="M226,88.63a4,4,0,0,0-6.77-1,77,77,0,0,0-8.5,12.77,8.91,8.91,0,0,0-.92,3.85c-.21.36-.85,1.51-1.6,3.17-.14.3-.28.62-.42,1A39.77,39.77,0,0,0,206,113.6c-.17.65-.33,1.31-.46,2-.06.3-.12.6-.17.91a10.48,10.48,0,0,0,0,3.27,17.27,17.27,0,0,0-1.61,5c-.1.46-.22,1-.34,1.51-.8,3.4.7,5.59,1.79,7.19a10.82,10.82,0,0,1,2.14,5.23c-.34,1.74-7.13,5.53-15.06,7.63a4,4,0,0,0-2.7,2.38c-1.06,2.65,0,5.49,2.61,7.24s7.1,2.66,12.06,2.66c7.17,0,15.28-2,19.87-6.59,8.42-8.42,12.17-17,12.17-27.83a35.69,35.69,0,0,0-.84-6.83c-.13-.66-.28-1.33-.44-2C232.48,104.3,226.84,90.57,226,88.63Zm-4,61.25c-4.08,4.08-11.33,5.68-17.62,5.68-4.52,0-8.55-.82-10.54-2.14s-1.73-3-1.48-3.62a1,1,0,0,1,.67-.6c4.71-1.24,18-5.9,17.26-10.89a13.83,13.83,0,0,0-2.64-6.56c-.95-1.39-1.84-2.7-1.35-4.81.13-.56.25-1.07.35-1.53.54-2.41.87-3.87,1.88-4.91a8.41,8.41,0,0,1-.24-3.49,36.06,36.06,0,0,1,4.13-11.35,1,1,0,0,1,.39-.37,6.43,6.43,0,0,1,.57-3.56,73.68,73.68,0,0,1,8.13-12.19,1,1,0,0,1,.92-.35,1,1,0,0,1,.77.6c.41,1,10.08,24.3,10.08,34.38S229.85,142.06,222,149.87Z"/><path class="cls-12" d="M215.23,102.61c-2.2,4.39,4.89,12.93,7.81,15.85a1,1,0,0,1-1.41,1.41c-.34-.34-6.14-6.2-8.13-11.9a34.18,34.18,0,0,0-3.18,9.36,8.81,8.81,0,0,0,1,4.91l6.79,9.34a1,1,0,0,1-1.52,1.29,40.28,40.28,0,0,1-7-9.61l-.22-.3a25.4,25.4,0,0,0-.74,2.88c-.11.47-.22,1-.35,1.55-.28,1.21.12,1.86,1.05,3.23a15.77,15.77,0,0,1,3,7.4c1,7.13-14.3,11.87-18.09,12.93a1.69,1.69,0,0,0,.75.79c4.24,2.79,19.58,2.77,25.64-3.29,7.4-7.41,10.71-14.9,10.71-24.29,0-8.23-7.09-26.56-9.28-32A69,69,0,0,0,215.23,102.61Z"/><path class="cls-13" d="M222.48,89.18a1,1,0,0,0-.92.35,73.68,73.68,0,0,0-8.13,12.19,6.43,6.43,0,0,0-.57,3.56,1,1,0,0,0-.39.37A36.06,36.06,0,0,0,208.35,117a8.41,8.41,0,0,0,.24,3.49c-1,1-1.34,2.5-1.88,4.91-.11.47-.22,1-.35,1.53-.5,2.11.4,3.42,1.35,4.81a13.83,13.83,0,0,1,2.64,6.56c.71,5-12.56,9.65-17.26,10.89a1,1,0,0,0-.67.6c-.25.63-.61,2.24,1.48,3.62s6,2.14,10.54,2.14c6.29,0,13.54-1.59,17.62-5.68,7.81-7.81,11.29-15.74,11.29-25.71s-9.67-33.4-10.08-34.38A1,1,0,0,0,222.48,89.18Zm-1.86,59.28c-6.06,6.06-21.41,6.08-25.64,3.29a1.69,1.69,0,0,1-.75-.79c3.79-1.06,19.11-5.81,18.09-12.93a15.77,15.77,0,0,0-3-7.4c-.93-1.37-1.33-2-1.05-3.23.13-.56.25-1.08.35-1.55a25.4,25.4,0,0,1,.74-2.88l.22.3a40.28,40.28,0,0,0,7,9.61,1,1,0,0,0,1.52-1.29l-6.79-9.34a8.81,8.81,0,0,1-1-4.91A34.18,34.18,0,0,1,213.5,108c2,5.71,7.79,11.56,8.13,11.9a1,1,0,0,0,1.41-1.41c-2.92-2.92-10-11.45-7.81-15.85a69,69,0,0,1,6.82-10.49c2.2,5.48,9.28,23.81,9.28,32C231.33,133.56,228,141.05,220.63,148.46Z"/><path class="cls-3" d="M174.11,19.71a.59.59,0,0,0,.39-.15,13.28,13.28,0,0,1,7.25-3,18.26,18.26,0,0,1,5.6.07.59.59,0,1,0,.2-1.16,19.35,19.35,0,0,0-6-.08,14.42,14.42,0,0,0-7.88,3.25.59.59,0,0,0,.39,1Z"/><path class="cls-3" d="M197.92,22.94a.59.59,0,0,0,.89-.77,23.25,23.25,0,0,0-2.58-2.54.59.59,0,0,0-.75.9A21.94,21.94,0,0,1,197.92,22.94Z"/><path class="cls-3" d="M147.32,36.68h14.12a.59.59,0,1,0,0-1.18H147.32a.59.59,0,1,0,0,1.18Z"/><path class="cls-3" d="M227.85,36.31a.59.59,0,1,0,1-.57c-.39-.69-1-1.78-1.88-3.05a.59.59,0,1,0-1,.65C226.85,34.58,227.47,35.64,227.85,36.31Z"/><path class="cls-3" d="M244.38,37.39h6.54a.59.59,0,1,0,0-1.18h-6.54a.59.59,0,1,0,0,1.18Z"/><path class="cls-3" d="M207.69,23.4a8.58,8.58,0,0,1,5.63-.61A14.72,14.72,0,0,1,220,26.33a.59.59,0,1,0,.77-.89,15.85,15.85,0,0,0-7.23-3.8,9.75,9.75,0,0,0-6.39.72.59.59,0,0,0,.54,1Z"/><path class="cls-3" d="M232.61,37.39h1.18a.59.59,0,0,0,0-1.18h-1.18a.59.59,0,0,0,0,1.18Z"/><path class="cls-3" d="M201.19,27.67a.59.59,0,1,0,1-.56c-.17-.32-.37-.68-.6-1a.59.59,0,0,0-1,.6C200.83,27,201,27.36,201.19,27.67Z"/><path class="cls-3" d="M171.06,30.57h.08a.59.59,0,0,0,.5-.66c-.05-.37-.09-.75-.13-1.14a.59.59,0,0,0-1.17.09c0,.37.07.73.12,1.08,0,0,0,.08,0,.13A.59.59,0,0,0,171.06,30.57Z"/><path class="cls-3" d="M173.23,36.41a.59.59,0,0,0,0-.56s-.25-.57-.56-1.48a.59.59,0,0,0-1.11.38c.1.29.19.54.27.76h-1a.59.59,0,0,0,0,1.18h1.89A.59.59,0,0,0,173.23,36.41Z"/><path class="cls-1" d="M146.88,41.9H251.65a1.18,1.18,0,0,0,0-2.35H227.31c-2.17-4-7.57-12.57-14.31-13.86-9-1.71-10.74,7.22-10.74,7.22s-6-15.48-21-13.43c-7.2,1-9.88,4.78-10.59,8.8a.59.59,0,0,1,.87.47c0,.39.07.77.13,1.14a.59.59,0,0,1-.5.66h-.08a.59.59,0,0,1-.58-.51s0-.08,0-.13A20.23,20.23,0,0,0,171,35.5h.86c-.08-.21-.17-.47-.27-.76a.59.59,0,0,1,1.11-.38c.31.91.56,1.47.56,1.48a.59.59,0,0,1-.54.83h-1.43a23.12,23.12,0,0,0,1,2.87H146.88a1.18,1.18,0,0,0,0,2.35Z"/><path class="cls-14" d="M160.64,89.66,162,94.09a12.5,12.5,0,0,1,2.87-3l-.76-2.46a.5.5,0,0,1,.19-.55,9.73,9.73,0,0,0,2.89-3.3,9.69,9.69,0,0,0-5.26-13.68l1.94,6.39A2,2,0,0,1,162.5,80l-5.31,1.61a2,2,0,0,1-2.52-1.35l-1.94-6.39A9.35,9.35,0,0,0,152,75a9.7,9.7,0,0,0,8.21,14.26A.5.5,0,0,1,160.64,89.66Z"/><path class="cls-15" d="M169.54,106.31l-.6-1.94a12.91,12.91,0,0,1-4.3-1.49l1.36,4.48a.5.5,0,0,1-.19.55,9.75,9.75,0,0,0-2.89,3.3,9.69,9.69,0,0,0,5.26,13.68l-1.94-6.39a2,2,0,0,1,1.35-2.52l5.31-1.61a2,2,0,0,1,2.52,1.35l1.94,6.39a9.29,9.29,0,0,0,.76-1.18A9.69,9.69,0,0,0,170,106.66.5.5,0,0,1,169.54,106.31Z"/><polygon class="cls-16" points="158.93 80.54 158.93 80.54 159.23 80.45 158.93 80.54"/><path class="cls-17" d="M162.83,97.67a3.92,3.92,0,0,0,1.9,2.91c2.16,1.56,5,2.07,5.79,1.81a1,1,0,0,1,.54,0c2.5-2.43,2.27-6.54,1-8.84a4.13,4.13,0,0,0-2.15-2,3.38,3.38,0,0,0-2.54.22C166.56,92.26,162.83,94.65,162.83,97.67Z"/><path class="cls-3" d="M92.87,13.95h.55a.59.59,0,1,0,0-1.18h-.55a.59.59,0,1,0,0,1.18Z"/><path class="cls-3" d="M50.08,5.15a.59.59,0,0,0,.45-.21,5.63,5.63,0,0,1,2.69-1.66.59.59,0,0,0-.35-1.13,6.8,6.8,0,0,0-3.24,2,.59.59,0,0,0,.45,1Z"/><path class="cls-3" d="M57.63,2.92a9.06,9.06,0,0,1,1.08.22l.16,0A.59.59,0,0,0,59,2a10.37,10.37,0,0,0-1.22-.25.6.6,0,0,0-.67.5A.59.59,0,0,0,57.63,2.92Z"/><path class="cls-3" d="M84.61,13.95h3.54a.59.59,0,1,0,0-1.18H84.61a.59.59,0,1,0,0,1.18Z"/><path class="cls-3" d="M50.36,13.54a.59.59,0,0,0-.59-.59H35.6a.59.59,0,0,0,0,1.18H49.77A.59.59,0,0,0,50.36,13.54Z"/><path class="cls-3" d="M67.08,9.95s0-.11.06-.24a4.38,4.38,0,0,1,4.13-3.43,5.93,5.93,0,0,1,1.11.11,9.48,9.48,0,0,1,4.67,2.73.59.59,0,0,0,.82-.85,10.62,10.62,0,0,0-5.27-3,7.11,7.11,0,0,0-1.33-.13,5.48,5.48,0,0,0-5.19,4,.59.59,0,0,0-.23.74l.09.21a.61.61,0,0,0,.55.38.59.59,0,0,0,.58-.47Z"/><path class="cls-1" d="M35.43,18.09H93.9a1.18,1.18,0,0,0,0-2.36H80.06c-1.2-2.21-4.22-7-8-7.75A4.62,4.62,0,0,0,67.14,9.7c0,.13-.06.22-.06.24a.59.59,0,0,1-.38.44A6.4,6.4,0,0,0,66.07,12S62.74,3.38,54.34,4.52c-6.18.84-6.4,5.4-5.82,8.43h1.25a.59.59,0,1,1,0,1.18h-1a12.79,12.79,0,0,0,.55,1.59H35.43a1.18,1.18,0,0,0,0,2.36Z"/><path class="cls-18" d="M105.71,86.16a1.56,1.56,0,0,0,.34,0,6.81,6.81,0,0,0,2-1.12,16.76,16.76,0,0,0,4.73-5.11,3.89,3.89,0,0,0,.36-3,2,2,0,0,0-1.58-1.33C109,75,101.34,76.84,98,80.87a2,2,0,0,0-.24,2.24c.82,1.61,5.11,2.79,7.24,3A6.39,6.39,0,0,0,105.71,86.16Z"/><rect id="_Slice_" data-name="&lt;Slice&gt;" class="cls-2" width="283" height="184"/></g></g></svg>

license header ?
Attachment #8923757 - Flags: review?(nchevobbe) → review+
Comment on attachment 8923758 [details]
Bug 1412504 - update styling for about:devtools;

https://reviewboard.mozilla.org/r/194900/#review199956

a couple of minor comments, but this is good to land

::: devtools/shim/aboutdevtools/aboutdevtools.xhtml:24
(Diff revision 1)
>  <body>
>    <div id="install-page" class="wrapper" hidden="true">
>      <div class="box">
>        <div class="left-pane" />
>        <div class="right-pane">
> -        <h1 class="installpage-title" id="common-title" hidden="true">&aboutDevtools.enable.title;</h1>
> +        <h1 class="title" id="common-title" hidden="true">&aboutDevtools.enable.title;</h1>

all `<h1>` tags have the `.title` class, could we remove it and apply the style on all `<h1>` tags instead ?

::: devtools/shim/aboutdevtools/aboutdevtools.xhtml:56
(Diff revision 1)
>      <div class="features">
>        <ul class="features-list">
>          <li class="feature">
>            <img class="feature-icon" src="chrome://devtools-shim/content/aboutdevtools/images/feature-inspector.svg" alt=""/>
>            <h3 class="feature-name">Inspector</h3>
> -          <p class="feature-desc">Inspect and refine code to build pixel-perfect layouts.</p>
> +          <p class="message feature-desc">Inspect and refine code to build pixel-perfect layouts.</p>

all `<p>` tags seem to have this `message` class. Can we remove it, and apply the style on all `<p>` tags ?
Attachment #8923758 - Flags: review?(nchevobbe) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fc72161667d
update otter image in about:devtools;r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/710ce0548f3a
update styling for about:devtools;r=nchevobbe
Removing from beta study blockers until we get actionable feedback.
No longer blocks: 1408339
Attached patch aboutdevtools-ui-fixes.patch (obsolete) — Splinter Review
Integrated the feedback from https://bugzilla.mozilla.org/show_bug.cgi?id=1408330#c21
Attachment #8927557 - Attachment is obsolete: true
Attachment #8927971 - Flags: review?(nchevobbe)
Comment on attachment 8927971 [details] [diff] [review]
aboutdevtools-ui-fixes.patch

Review of attachment 8927971 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8927971 - Flags: review?(nchevobbe) → review+
thanks for the review! landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/734949a8f6d1
Style updates for about:devtools;r=nchevobbe
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/734949a8f6d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
This is looking so good on Nightly! I went through all the pages again to do one more review. I saw two minor text issues that could be changed:

The Inspect Element page body says "...close this tab" but the button says "Close this page." I think it would be better to say "Tab" (capitalized) on the button for all pages.

Inspect Element page text: I think the apostrophe in "the Developer Tools’ Inspector" is unnecessary and should be removed.
Flags: needinfo?(jdescottes)
Oops, actually one more style thing - after consulting with my UX colleague antlam, I decided the top-padding change was too jarring between the two page types.

Could we make this change to #welcome-page .box?

padding: 17% 0 100px 0;

And could we do this for #install-page .box? (ideally substituting 15px with actual scrollbar width)

padding: 17% 15px 50px 0;

This way, the otter will be perfectly aligned between the two pages :)
Thanks for the updates Victoria! Opened another follow up bug to address those: Bug 1418952 (ongoing bugs are not compatible with mozreview, it will be easier for me to create new bugs).
Flags: needinfo?(jdescottes)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.