141251 - ViewSource does not respect my chosen colors

Status: RESOLVED DUPLICATE of bug 1502552

(Toolkit :: View Source, defect)

Description

[calocybe]

The background color of the viewsource window is always white, at least in RC1
on WinNT. This is probably a necessity if syntax highlighting is on (but it
would be fine to have some means to adjust all aspects of highlighting to
personal prefs). However, it's annoying to have the white background even in
plain viewsource mode. Instead, the same colors should be used, that are used
for normal browsing, if a page doesn't specify its own colors (that is, the
colors which are set in the prefs).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Except view-source is not a webpage... it's part of the interface.  You're not
complaining that the background of the JS console is always white, are you?  :)

That said, we _could_ follow the prefs in non-highlighted mode...  Doron, if you
decide we should, feel free to reassign the bug to me.

Comment 2

[calocybe]

Yes, I *would* be complaining about the JS console as well, if it *was* white.
But it isn't, and I'm very happy about that. ;-) But your argument is ok, anyway.

Comment 3

[Nicholas Allen]

I'm really confused win2k 20020428 trunk

Background color of view source changes with my color pref.
JS console is always white.

This seems to be the opposite of the branch :)

Comment 4

[Doron Rosenberg (IBM)]

do what you want to do :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bah.  :)

Taking bug.  Doron, please let me know if you have any plans to make syntax
highlighting dynamically toggle-able from the view-source window, because my
planned fix would basically make that impossible...

Comment 6

[calocybe]

Boris, now that you said viewsource is not a webpage, I consider that it migth
be more appropriate to use suitable system colors instead of the colors set in
the prefs. (In my case it's the same anyway.) Or it might be dependent on the
selected theme... Uhm, I'm sure you'll find the best way... ;-)

ac_gyrefalcon: Interesting. ;-) Might there be a relation to the selected theme?
I use the "Classic" theme. (I would use "Modern" if it hadn't that disgusting
white background for the mail window. :-( )

Comment 7

[R.K.Aa.]

bug 149833 seems to say the opposite of this  bug?

Comment 8

[calocybe]

Not really. That guy has the "[Always] Use my chosen colors" option set.
I opted to let webpages choose their own colors, but think that view-source
should still use *my* colors instead of some arbitrary ones
(black on white), at least if Syntax highlighting is off.
If I choose "always use my colors", I get my chosen colors, too (and syntax
highlighting seems to be switched off automatically).

However, Boris pointed out that view-source is not a web page, thus it might be
better to gain the color specs from somewhere else, e.g. the system colors or
the selected theme. The main point is, it should not have white background
unless that is the user's desire.

Comment 9

[Boris Zbarsky [:bzbarsky]]

1.1beta is upon us and I am still swamped with much higher priority stuff... 

Ideas on how to actually select the colors to use would be much appreciated...

Note that we could just load a stylesheet from the theme and then themes could
provide their own view-source stylesheets and be happy... That may be the
simplest way to go.

Comment 10

[calocybe]

> Ideas on how to actually select the colors to use would be much appreciated...
> Note that we could just load a stylesheet from the theme and then themes could
> provide their own view-source stylesheets and be happy...

Stylesheets... that's a good point. Meanwhile, I found the viewsource.css in the
res directory. I modified the file to suit my needs, and now I see the old
Netscape4 view-source colors here. That's fine for me, but since that file lives
in an area that should be writeable by root/Administrator only, this is not a
universally feasible approach.

However, if one could easily place another viewsource.css in one's profile
directory, user-defined directives from this file could override those from the
global viewsource.css according to the CSS cascading rules. But, wouldn't this
procedure be generally useful for *all* UI aspects? Having the UI generally
specified by global resources, those overridden by the selected theme, and parts
of the theme overridden again by user tweaking? Guess I should file a new bug,
what do you think?

Comment 11

[Boris Zbarsky [:bzbarsky]]

userChrome.css in the "chrome" directory of a profile will already override a
theme's stylesheets.

userContent.css in the same directory will override the default webpage
rendering and (due to an internal implementation issue) the viewsource rendering.

So you could in fact style viewsource with userContent.css (which I feel is
somewhat wrong, by the way).

Comment 12

[Boris Zbarsky [:bzbarsky]]

No plans to work on this any time in the foreseeable future, so to default owner.

Comment 13

[lucianolll]

Translation for the English

 Also I observed that the deep one; background of page VIEW-PAGE-SOURCE must
have a deep one; background configured by the user;
 The same if of; I observe; for the ackward pages of navigation that the reading
for having deep configured white;
 The huge idea to implant in browser Mozilla;
 SUGGESTION; In Navigator the Appearance as it follows;
 
------------------------------------------------------------------------------------
  | File Edit View Go Bookmarks Tools Widow bgColor Help        | #bgColor * 1 |
    |
 
------------------------------------------------------------------------------------
 Suggestion of being made accurately as this drawing of the bar of navigation;
 Different for the Navigator and an other for the page of View-Page-Source;
 IMPORTANT
 As much for pages of WebSites; how much for the page of View-Page-Source Thus
the user can permanently control the appearance of the deep one of the pages;
How much to the Foreground this still can remain as standard; What it has caused
I bother is the configuration of deep white;
 SUGGESTION
 * the 1 With a click of mouse and page this configured as well as the others
that will come after; preventing the consuming of the visibility of the page; Or
better explaining in code;
 * 1
 < input value = "# bgColor * 1" onblur="document.bgColor='#bgColor * 1'"/>

 * 1 color Background configured by the user;
 As example # FFDFBF;#FFE3C6;#FFE7CC;#FFECD7;
 This in such a way for the pages of normal navigation if sites Web; How much
for the VIEW-PAGE-SOURCE page; equally; The pages would be decided how much the
deep white; As much the pages of Websites how much the pages generated in
View-Page-Source Being enough to the user to choose a time; being able to change
to the proper desire easily and; I have read extensive pages and the deep white
is harmful; ackward;
 Thus Mozilla Navigator will be more dynamic; it will be more practical; special;




Tradução para o Português


Também observei que o fundo; o background da página VIEW-PAGE-SOURCE deve ter um
fundo; background configurado pelo usuário;
O Mesmo se da; observo; para as páginas de navegação que desagradáveis a leitura
por terem fundo branco configurado;
A idéia grandiosa para implantar no browser Mozilla; SUGESTÃO ;
Em Navegador a Aparência como segue;

   ---------------------------------------------------------------------------
   | File Edit View Go Bookmarks Tools Widow Help      | #bgColor *1 |       |
   ---------------------------------------------------------------------------

Sugestão de ser feito exatamente como este desenho da barra de navegação;
Uma diferente para o Navegador e outra para a página de View-Page-Source;

 ---------       IMPORTANTE      ---------------------
Tanto para páginas de WebSites ; quanto para a página de View-Page-Source
Assim o usuário pode controlar permanentemente a aparência do fundo das páginas;
Quanto ao Foreground este ainda pode permanecer como padrão; O que tem causado
incomodo é a configuração de fundo branco;

 ---------       SUGGESTION      ---------------------
*1 Com um clique do mouse e a página esta configurada assim como as outras que
virão após;
evitando o desgaste da visibilidade da página;
Ou melhor explicando em código;
*1
<input value=" #bgColor *1 " onblur="document.bgColor='#bgColor *1'" />

*1 Background color configurada pelo usuário
Como exemplo #FFDFBF ;#FFE3C6 ;#FFE7CC ;#FFECD7 ;

Isto tanto para as páginas de navegação normal se sites Web;
Quanto para a página de VIEW-PAGE-SOURCE ; igualmente ;


As páginas estariam resolvidas quanto ao fundo branco;
Tanto as páginas de Websites quanto as páginas geradas em View-Page-Source

Bastando ao usuário escolher uma vez; podendo trocar ao desejo próprio e facilmente;

Tenho lido páginas extensas e o fundo branco é nocivo; desagradável;

Assim o Navegador Mozilla será mais dinâmico; será mais prático; especial;

Comment 14

[lucianolll]

 ####################
file:///C:/Arquivos de programas/Mozilla Firefox/res/viewsource.css

 to edit this

 ----------------
*|*:root {
  background-color: #f6fff4;
}
 ----------------


 ####################

Comment 15

[Philip Chee]

SeaMonkey trunk is now using toolkit viewsource.

Comment 16

[IdmFoundInHim]

Bug 1502552 makes more sense for continued work on the issue