1412542 - Massive Mozmill failure: PROCESS-CRASH | account | application crashed [@ Servo_AnimationValue_Opacity]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jorg K (CEST = GMT+2)]

TB's Mozmill runs on all platforms and regardless of whether opt or debug now crash with:

PROCESS-CRASH | account | application crashed [@ Servo_AnimationValue_Opacity]

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=395acea4a3e753488ca38d56c51654d151d50d6c
(Click onto the red Z's).

Sample log:
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-linux64-debug/1509194481/comm-central_ubuntu64_vm-debug_test-mozmill-1-bm54-tests1-linux64-build181.txt.gz

07:10:16  WARNING -  PROCESS-CRASH | account | application crashed [@ Servo_AnimationValue_Opacity]
07:10:16     INFO -  Crash dump filename: /builds/slave/test/build/tests/mozmill/mozmillprofile/minidumps/371535f2-c8fb-69e2-d842-33192f688006.dmp
07:10:16     INFO -  Operating system: Linux
07:10:16     INFO -                    0.0.0 Linux 3.2.0-76-generic #111-Ubuntu SMP Tue Jan 13 22:16:09 UTC 2015 x86_64
07:10:16     INFO -  CPU: amd64
07:10:16     INFO -       family 6 model 45 stepping 7
07:10:16     INFO -       1 CPU
07:10:16     INFO -  GPU: UNKNOWN
07:10:16     INFO -  Crash reason:  SIGSEGV
07:10:16     INFO -  Crash address: 0x0
07:10:16     INFO -  Process uptime: not available
07:10:16     INFO -  Thread 20 (crashed)
07:10:16     INFO -   0  libxul.so!Servo_AnimationValue_Opacity [ServoBindingList.h:c16bc8097c10 : 373 + 0x5]
07:10:16     INFO -      rax = 0x0000000000000000   rdx = 0x0000000000000000
07:10:16     INFO -      rcx = 0x00007f5b79f90fed   rbx = 0x00007f5b592fd2c8
07:10:16     INFO -      rsi = 0x00007f5b7a264a80   rdi = 0x00007f5b7a263180
07:10:16     INFO -      rbp = 0x00007f5b592fd240   rsp = 0x00007f5b592fd240
07:10:16     INFO -       r8 = 0x00007f5b592fe700    r9 = 0x0000000000000034
07:10:16     INFO -      r10 = 0x756e672d78756e69   r11 = 0x0000000000000000
07:10:16     INFO -      r12 = 0x00007f5b592fd258   r13 = 0x00007f5b3ddf74a8
07:10:16     INFO -      r14 = 0x00007f5b45ff01a8   r15 = 0x00007f5b413ac270
07:10:16     INFO -      rip = 0x00007f5b6e8fb7cc
07:10:16     INFO -      Found by: given as instruction pointer in context
07:10:16     INFO -   1  libxul.so!mozilla::AnimationValue::Opacity [StyleAnimationValue.cpp:c16bc8097c10 : 5507 + 0x9]
07:10:16     INFO -      rbx = 0x00007f5b592fd2c8   rbp = 0x00007f5b592fd270
07:10:16     INFO -      rsp = 0x00007f5b592fd250   r12 = 0x00007f5b592fd258
07:10:16     INFO -      r13 = 0x00007f5b3ddf74a8   r14 = 0x00007f5b45ff01a8
07:10:16     INFO -      r15 = 0x00007f5b413ac270   rip = 0x00007f5b6e90641b
07:10:16     INFO -      Found by: call frame info

and more.

M-C last good: d58424c244c3
M-C first bad: c16bc8097c10

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d58424c244c3&tochange=c16bc8097c10

Looks like bug 1340005 caused this.

Also NI'ing Boris since he's a Servo guy, right?

Comment 1

[Boris Chiou [:boris]]

Sorry, it's my fault. How do I reproduce this in m-c?

Brian, could you please help me check this bug? Thanks.

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Boris Chiou [:boris] (away 24 Oct – 12 Nov) from comment #1)
> Sorry, it's my fault. How do I reproduce this in m-c?
That's a jolly good question. This got landed and didn't cause any problems in FF, but on Mozilla's secondary testing ground, Thunderbird, there are problems.

TB Mozmill means that we actually start the application and render the UI onto the screen. I understand that Servo is the new layout engine, so since there is XUL/HTML to layout, Servo will spring into action.

Thinking out aloud, TB is actually compiled with |ac_add_options --disable-stylo|
https://dxr.mozilla.org/comm-central/source/build/mozconfig.stylo#3

So that may be the root cause here. Bug 1340005 is the first deployment of Servo to the desktop? Perhaps we should work on building TB with stylo.

Comment 3

[Boris Chiou [:boris]]

Thanks! It seems we should also avoid going into the stylo branch for other products, such as Thunderbird. i.e. I have to update the animation condition on the compositor thread.

Comment 4

[Boris Chiou [:boris]]

Attachment: Fix crashes on products other than Firefox.

MozReview-Commit-ID: G9DeMR5o8F3

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1412542 - Fix crashes on products other than Firefox.

Review commit: https://reviewboard.mozilla.org/r/194306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194306/

Comment 6

[Boris Chiou [:boris]]

Hi Jorg, could you please try the patch I just uploaded? Hope it could fix the problem.

Comment 7

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ec2b7f57000e38bcd34a2d0220f2b12f63658d48

In a while, you will see Z's. They will be red since we have other bustage. But if you're crash doesn't show, then the crash is gone.

I'll check it myself in two hours and report back here. I don't have an up-to-date local build right now, hence the try.

BTW, thanks for the super-fast action!

Comment 8

[Jorg K (CEST = GMT+2)]

I ran a build without the patch and got:
MozCrashReason: MOZ_CRASH(stylo: shouldn't be calling Servo_AnimationValue_Transformin a non-stylo build)

Comment 9

[Boris Chiou [:boris]]

(In reply to Jorg K (GMT+2) from comment #8)
> I ran a build without the patch and got:
> MozCrashReason: MOZ_CRASH(stylo: shouldn't be calling
> Servo_AnimationValue_Transformin a non-stylo build)

Yes, obviously we shouldn't call any Servo FFI on Thunderbird.

Comment 10

[Cameron McCormack (:heycam)]

Comment on attachment 8923116 [details]
Bug 1412542 - Fix crashes on products other than Firefox.

https://reviewboard.mozilla.org/r/194306/#review199248

r=me with the MOZ_STYLO_ENABLE check removed.

::: gfx/config/gfxVars.h:50
(Diff revision 1)
>    /* Add new entries above this line. */
>  
>  // Define the default animation backend on the compositor. Now we don't use
>  // stylo on the compositor only on Android, and this is a fixed flag. If
>  // we want to update this flag, please add a new gfxVars for it.
> -#if defined(ANDROID)
> +#if defined(MOZ_STYLO) && defined(MOZ_STYLO_ENABLE) && !defined(ANDROID)

I don't think we need to check MOZ_STYLO_ENABLE, do we?  That just controls whether stylo is enabled by default, when MOZ_STYLO is defined.  And all we care about here is that Stylo wasn't compiled in.

Comment 11

[Boris Chiou [:boris]]

Comment on attachment 8923116 [details]
Bug 1412542 - Fix crashes on products other than Firefox.

https://reviewboard.mozilla.org/r/194306/#review199248

> I don't think we need to check MOZ_STYLO_ENABLE, do we?  That just controls whether stylo is enabled by default, when MOZ_STYLO is defined.  And all we care about here is that Stylo wasn't compiled in.

Thanks, heycam. I will remove that.

Comment 12

[Boris Chiou [:boris]]

Comment on attachment 8923116 [details]
Bug 1412542 - Fix crashes on products other than Firefox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194306/diff/1-2/

Comment 13

[Boris Chiou [:boris]]

(In reply to Jorg K (GMT+2) from comment #7)
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=ec2b7f57000e38bcd34a2d0220f2b12f63658d48
> 
> In a while, you will see Z's. They will be red since we have other bustage.
> But if you're crash doesn't show, then the crash is gone.
> 
> I'll check it myself in two hours and report back here. I don't have an
> up-to-date local build right now, hence the try.
> 
> BTW, thanks for the super-fast action!

It seems the crashes are gone, so please feel free to push the button in MozReview because my gecko try looks good now.

Comment 14

[Jorg K (CEST = GMT+2)]

Yes, the crashes are gone, thanks. I don't know anything about MozReview, so I wouldn't know which button to push.

Comment 15

[Boris Chiou [:boris]]

I see. I just pushed it into autoland. Thanks for the verification.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de6dc315e29c
Fix crashes on products other than Firefox. r=heycam

Comment 17

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/mozilla-central/rev/de6dc315e29c

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/de6dc315e29c