Closed Bug 1412555 Opened 2 years ago Closed 2 years ago

Update canvas position on scroll in the css grid highlighter

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

In Bug 1409970, we forgot to update the canvas position after calling getCanvasPosition on scroll.
The consequence of this is that infinite lines don't necessarily work. To see this, enable the css grid highlighter w/ infinite lines in https://www.mozilla.org/en-US/developer/css-grid/ and scroll
Comment on attachment 8923117 [details]
Bug 1412555 - Update canvas position on scroll in the css grid highlighter.

https://reviewboard.mozilla.org/r/194310/#review200970
Attachment #8923117 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de37bff8b033
Update canvas position on scroll in the css grid highlighter. r=pbro
https://hg.mozilla.org/mozilla-central/rev/de37bff8b033
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.