1412557 - [macOS] Regression: Window Control Buttons are 1px lower now than before

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect, P3)

Description

[Mehmet]

macOS 10.12.6
58.0a1 (2017-10-28) (64-Bit)

1.) Open a new window
2.) Take a look at the position of the Window Control Buttons with and without Drag Space.

Actual: They are 1px lower than before.

Expected: They should be 1px higher to be vertically centered on the Toolbar.

This is a regression.

Good: 2017-10-24-22-03-25
 Bad: 2017-10-25-10-04-49 

May be caused https://hg.mozilla.org/mozilla-central/rev/f5121cba7d7b?

If you need screenshots, please let me know.

Comment 1

[Mehmet]

Hello Dão, can you please check, if this is caused by your change from https://hg.mozilla.org/mozilla-central/rev/f5121cba7d7b ?

Thanks :-)

Comment 2

[Mehmet]

Attachment: Expected_vs_Actual

Please find attached a screenshot comparing Expected vs Actual. Thanks.

Comment 3

[Johann Hofmann [:johannh]]

This change counterbalanced the window controls moving up in bug 1402309, and in triage we said that this now actually looks well centered to us. I'm closing this bug as WONTFIX unless UX decides to revisit this.