Bug 1412617 - Click event should be propagated to video element when clicking on the area other than controlBar.
59 bytes, text/x-review-board-request
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20171028220326 Steps to reproduce: Open https://jsfiddle.net/kkeevova/1/ Click on video. Actual results: Only the first two event listeners are run, adding the lines body capture video capture to the textarea element. Expected results: All four event listeners should be run, adding the lines body capture video capture video bubble body bubble as happens in Firefox 56.0.
Component: Untriaged → DOM: Events
Product: Firefox → Core
Not an issue in DOM events, but something in video control. -> Audio/Video
Component: DOM: Events → Audio/Video
http://searchfox.org/mozilla-central/rev/831f2ed98fd6fe85d1e775d67e5da2d419608551/toolkit/content/widgets/videocontrols.xml#1541 looks suspicious, as an example. That code should probably use system group event listeners. http://searchfox.org/mozilla-central/source/dom/webidl/EventTarget.webidl#14,18
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blake, I see your team seem to be taking care of media controls, these days :-) Do you have someone to have a look at this one?
Component: Audio/Video → Video/Audio Controls
Product: Core → Toolkit
Take this as bug 1402877 introduced the changes, thanks.
Assignee: nobody → ralin
(In reply to Olli Pettay [:smaug] from comment #2) > http://searchfox.org/mozilla-central/rev/ > 831f2ed98fd6fe85d1e775d67e5da2d419608551/toolkit/content/widgets/ > videocontrols.xml#1541 > looks suspicious, as an example. > That code should probably use system group event listeners. > http://searchfox.org/mozilla-central/source/dom/webidl/EventTarget.webidl#14, > 18 Indeed, though it might be a problem only if user clicks on closed caption menu, I'll fix it as well in this bug.
status-firefox57: --- → wontfix
Priority: -- → P3
Comment on attachment 8925432 [details] Bug 1412617 - Click event should be propagated to video element when clicking on the area other than controlBar. some ongoing discussions about desired behavior on Bug 1402877 comment 36.
Attachment #8925432 - Flags: review?(jaws)
Why this hasn't been fixed for 58 release? Do you realize you've broken all sites which listen for simple click event on video element?..
Anything we can do here ?
It looks like there was no follow-up to bug 1402877 comment 38. I'm guessing that is the first place to start. Unfortunately we don't have anybody that is assigned to work on video controls and I don't suspect ralin will be picking this bug up again. Paul or Kagami, would either of you be interested in working on this?
It's gotten worse as of Nightly 60.0a1 (2018-01-24) (64-bit); I don't even see the capture events anymore. And I'm not seeing mousedown or mouseup events either.
This might be an issue of difference of interpretation of >If the user agent exposes a user interface to the user by displaying controls over the media element, then the user agent should suppress any user interaction events while the user agent is interacting with this interface. (For example, if the user clicks on a video's playback control, mousedown events and so forth would not simultaneously be fired at elements on the page.) https://html.spec.whatwg.org/multipage/media.html#attr-media-controls where I would expect "controls" to mean just the bar at the bottom, whereas the implementer is perhaps taking the "controls" to be entire video area since clicking on the video plays/pauses it. In Chrome there is no confusion since it does not play/pause videos when clicked on.
>It's gotten worse as of Nightly 60.0a1 (2018-01-24) (64-bit); I don't even see the capture events anymore. And I'm not seeing mousedown or mouseup events either. Also seeing this in 59.0b3.
>This might be an issue of difference of interpretation of [spec] This is apparently the case: https://bugzilla.mozilla.org/show_bug.cgi?id=1327097#c88
(In reply to ccd0 from comment #13) > >It's gotten worse as of Nightly 60.0a1 (2018-01-24) (64-bit); I don't even see the capture events anymore. And I'm not seeing mousedown or mouseup events either. > Also seeing this in 59.0b3. I am experiencing the same, as Foxy Gestures no longer responds to mouse events on video elements while the controls are displayed. Previously, gestures worked as expected on video elements with controls. Does anyone know if there is an about:config preference to force video controls hidden by default?
You need to log in before you can comment on or make changes to this bug.