Click event listeners on bubble phase not run for video elements with controls

NEW
Assigned to

Status

()

Toolkit
Video/Audio Controls
P3
normal
22 days ago
14 days ago

People

(Reporter: ccd0, Assigned: ralin)

Tracking

58 Branch
Points:
---

Firefox Tracking Flags

(firefox57 wontfix)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

22 days ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171028220326

Steps to reproduce:

Open
https://jsfiddle.net/kkeevova/1/

Click on video.


Actual results:

Only the first two event listeners are run, adding the lines

body capture
video capture

to the textarea element.


Expected results:

All four event listeners should be run, adding the lines

body capture
video capture
video bubble
body bubble

as happens in Firefox 56.0.

Updated

22 days ago
Component: Untriaged → DOM: Events
Product: Firefox → Core

Comment 1

22 days ago
Not an issue in DOM events, but something in video control. -> Audio/Video
Component: DOM: Events → Audio/Video

Comment 2

22 days ago
http://searchfox.org/mozilla-central/rev/831f2ed98fd6fe85d1e775d67e5da2d419608551/toolkit/content/widgets/videocontrols.xml#1541 
looks suspicious, as an example.
That code should probably use system group event listeners.
http://searchfox.org/mozilla-central/source/dom/webidl/EventTarget.webidl#14,18
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blake, I see your team seem to be taking care of media controls, these days :-)

Do you have someone to have a look at this one?
Component: Audio/Video → Video/Audio Controls
Flags: needinfo?(bwu)
Product: Core → Toolkit
(Assignee)

Comment 4

21 days ago
Take this as bug 1402877 introduced the changes, thanks.
Assignee: nobody → ralin
Flags: needinfo?(bwu)
(Assignee)

Comment 5

21 days ago
(In reply to Olli Pettay [:smaug] from comment #2)
> http://searchfox.org/mozilla-central/rev/
> 831f2ed98fd6fe85d1e775d67e5da2d419608551/toolkit/content/widgets/
> videocontrols.xml#1541 
> looks suspicious, as an example.
> That code should probably use system group event listeners.
> http://searchfox.org/mozilla-central/source/dom/webidl/EventTarget.webidl#14,
> 18
Indeed, though it might be a problem only if user clicks on closed caption menu, I'll fix it as well in this bug.
status-firefox57: --- → wontfix
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Comment 7

14 days ago
Comment on attachment 8925432 [details]
Bug 1412617 - Click event should be propagated to video element when clicking on the area other than controlBar.

some ongoing discussions about desired behavior on Bug 1402877 comment 36.
Attachment #8925432 - Flags: review?(jaws)
You need to log in before you can comment on or make changes to this bug.