Closed
Bug 1412644
Opened 7 years ago
Closed 6 years ago
[Static Analysis] Uninitialized fields in some classes of widget
Categories
(Core :: Widget, defect, P3)
Core
Widget
Tracking
()
RESOLVED
DUPLICATE
of bug 1453795
People
(Reporter: tristanbourvon, Assigned: tristanbourvon)
References
Details
(Keywords: csectype-uninitialized, sec-moderate)
Attachments
(1 file, 1 obsolete file)
10.20 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the widget module.
Assignee | ||
Comment 1•7 years ago
|
||
By the way, who should I r? for the patch?
Updated•7 years ago
|
Assignee: nobody → tristanbourvon
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 2•7 years ago
|
||
Fix some coding style issues.
Attachment #8923162 -
Attachment is obsolete: true
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Attachment #8923763 -
Flags: review?(jmathies)
Updated•7 years ago
|
Keywords: csectype-uninitialized,
sec-moderate
Updated•7 years ago
|
Group: core-security → layout-core-security
Updated•7 years ago
|
Attachment #8923763 -
Flags: review?(jmathies) → review+
Comment 3•6 years ago
|
||
What are the next steps here? Can we land this patch?
Flags: needinfo?(tristanbourvon)
Flags: needinfo?(jmathies)
Assignee | ||
Comment 4•6 years ago
|
||
I can take a look at it in a few days.
Flags: needinfo?(tristanbourvon)
Updated•6 years ago
|
Flags: needinfo?(jmathies)
Assignee | ||
Comment 5•6 years ago
|
||
So after taking a look at this, it seems that everything was fixed in the large bundle of fixes from 1453795.
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Comment 7•6 years ago
|
||
Great! Thanks for looking into it.
Updated•6 years ago
|
Group: layout-core-security → core-security-release
Updated•2 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•