Closed Bug 1412645 Opened 2 years ago Closed 2 years ago

[Static Analysis] Uninitialized fields in some classes of widget/cocoa

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: tristanbourvon, Assigned: tristanbourvon)

References

Details

(Whiteboard: [adv-main58+])

Attachments

(1 file)

As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the widget/cocoa module.
Attachment #8923164 - Flags: review?(mstange)
Blocks: 1411595
Comment on attachment 8923164 [details] [diff] [review]
widget_cocoa.patch

Review of attachment 8923164 [details] [diff] [review]:
-----------------------------------------------------------------

Please put each of these on a separate line, to match the style of the surrounding code.
Attachment #8923164 - Flags: review?(mstange) → review+
Assignee: nobody → tristanbourvon
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/fff30c59e02e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Group: core-security → core-security-release
Whiteboard: [adv-main58+]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.