1412773 - Too much recursion on Lenovo shopping website

Status: RESOLVED DUPLICATE of bug 1244280

(Core :: JavaScript Engine, defect, P1)

Description

[Tooru Fujisawa [:arai]]

Attachment: stack trace

Steps to reproduce:
  1. Open Nightly 58.0a1 2017-10-29 (64 bit) on linux (ubuntu)
  2. Open https://www3.lenovo.com/jp/ja/jpad/notebooks/thinkpad/t-series/T470s/p/20HGCTO1WWJAJP8/customize
  3. Wait for a while for network requests

Actual result:
  'too much recursion' singlePage.js:5977:22
  shown in web console, and throbber keeps rolling
  attached web console output

Expected result:
  no error and throbber disappears

this might be region specific (since the website offers different locales), I'm testing from Japan.

Comment 1

[Jason Orendorff [:jorendorff]]

Wow, that is not that many stack frames. Doesn't happen for me (using Nightly 2017-10-30 on MacOS).

Arai, do you have time to debug this?

Comment 2

[Tooru Fujisawa [:arai]]

Yes, I'll try.

forgot to mention:
  * this doesn't happen for me on macOS
  * this happens on 2 linux machines (both ubuntu)
  * this happens also on 56.0.2

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: full backtrace from js::DumpBacktrace

happened also on debian VM.
and here's full backtrace.

Comment 4

[Tooru Fujisawa [:arai]]

note for myself
http://searchfox.org/mozilla-central/rev/1c4901d060e3953e41088c038b62a0c026c1e1fb/js/xpconnect/src/XPCJSContext.cpp#1011-1093

Comment 5

[Jan de Mooij [:jandem]]

Yes our recursion limits on Linux are too low. See also bug 1244280.

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: each function and surrounding context

so, in the full backtrace, there's at least 805 frames, and frame 0-795 consist of only 16 places in singlePage.js.

the call happens like the following:

+---+
|   |
|  Backbone.loadTemplate @ singlePage.js:11254
|   ^
|   |
|  this.renderTemplate @ singlePage.js:9796
|   ^                                  ^
|   |                                  |
|   |                                  +---------------+
|   |                                                  |
|  appendNextSubGroup @ singlePage.js:27655            |
|   ^                                                  |
|   |                                                  |
|  renderGroup @ singlePage.js:26693                   |
|   ^                                                  |
|   |                                                  |
|  renderGroups @ singlePage.js:26415                  |
|   ^                                                  |
|   |                                                  |
|  renderGroup callback @ singlePage.js:26423          |
|   ^                                                  |
|   |                                                  |
|  appendNextSubGroup callback @ singlePage.js:26694   |
|   ^                                                  |
|   |                                                  |
|  renderRadioGroup callback @ singlePage.js:27719     |
|   ^                                                  |
|   |                                                  |
|  renderCallback @ singlePage.js:28112                |
|   ^                                                  |
|   |                                                  |
|   |                      +---------------------------+
|   |                      |
|   |                   renderRadioGroup @ singlePage.js:28106
|   |                      ^
|   |                      |
|   |                   renderCallback @ singlePage.js:27715
|   |                      ^
|   |                      |            "Too much recursion"
|   |                      |             ^
|   |                      |             |
|   |                      |            template @ singlePage.js:5977
|   |                      |             ^
|  render @ singlePage.js:10026          |
|   ^                                   render @ singlePage.js:10001
|   |                                    ^
|   |                                    |
|  Backbone.loadTemplate callback @ singlePage.js:9803
|   ^  ^
|   |  |
+---+  |
       |
      success in ajax callback in Backbone.loadTemplate @ singlePage.js:11239
       ^
       |
      somewhere in dtagent.js

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: singlePage.js

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: dtagent_ICA23hjpqrx_6000500251013.js

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 56.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 57, but we could still take a patch for 58.

Comment 11

[Tooru Fujisawa [:arai]]

this should be fixed by bug 1244280.
I'll check again once nightly with it is out.

Comment 12

[Tooru Fujisawa [:arai]]

ni? myself to check again on linux env with latest nightly.

Comment 13

[Tooru Fujisawa [:arai]]

confirmed this is fixed by bug 1244280.
I'll ask uplift there.

Comment 14

[Tooru Fujisawa [:arai]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Too late for a fix for 57, but we could still take a patch for 58.

oops, I misinterpret the comment.
so, bug 1244280 patch is landed to 58, and there's nothing remaining to do.

Comment 15

[Tooru Fujisawa [:arai]]

confirmed this is fixed by bug 1244280.
I'll ask uplift there.

Comment 16

[Tooru Fujisawa [:arai]]

sorry for spam :P