1412949 - Some code in SystemMemoryReporter might be dead code

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Marco Castelluccio [:marco]]

I've noticed LinuxUtils.cpp is completely uncovered by tests (https://codecov.io/gh/marco-c/gecko-dev/src/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/xpcom/base/LinuxUtils.cpp).
The portions of SystemMemoryReporter.cpp which are supposed to call LinuxUtils.cpp are not covered too (https://codecov.io/gh/marco-c/gecko-dev/src/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/xpcom/base/SystemMemoryReporter.cpp).

Should we remove these portions now that Firefox OS is no longer actively developed and Firefox probably doesn't have access to those system directories?

Comment 1

[Nicholas Nethercote [inactive]]

It's not completely dead... that code is behind the memory.system_memory_reporter pref, which is false by default. You can turn it on and it works. But it's probably not useful, so I'll write a patch to remove it.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove SystemMemoryReporter

jld, can you see any reason not to remove this?

Comment 3

[Eric Rahm [:erahm]]

Comment on attachment 8923646 [details] [diff] [review]
Remove SystemMemoryReporter

Review of attachment 8923646 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of sad to see these go, but I can't think of a good reason to keep them. Can you update the about:memory docs [1] as well?

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Performance/about:memory#System

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8923646 [details] [diff] [review]
Remove SystemMemoryReporter

I can't think of a good reason to keep this either.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d76af6611465cfccaec40098493eedcd0ba1298b
Bug 1412949 - Remove SystemMemoryReporter. r=erahm.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d76af6611465
Remove SystemMemoryReporter. r=erahm.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d76af6611465