Closed
Bug 1412980
Opened 7 years ago
Closed 7 years ago
Remove nsPackageKitService as it is dead code
Categories
(Firefox :: Shell Integration, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
15.23 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
From the code coverage report, it looks like this file is never executed during tests. From a quick inspection, it looks like dead code to me.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8923559 -
Flags: review?(nfroyd)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8923559 [details] [diff] [review] Patch Review of attachment 8923559 [details] [diff] [review]: ----------------------------------------------------------------- I agree, this looks like dead code.
Attachment #8923559 -
Flags: review?(nfroyd) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6341b02a921c Remove nsPackageKitService as it is unused. r=froydnj
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6341b02a921c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
|
Assignee | |
Updated•7 years ago
|
Blocks: deadcode-codecoverage
You need to log in
before you can comment on or make changes to this bug.
Description
•