Closed
Bug 1413005
Opened 7 years ago
Closed 7 years ago
test-verify sometimes tries to verify a test that should have been skipped, because it is skipped on e10s
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
|
1006 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
TV should not try to verify skipped tests skipped in manifestparser-compatible manifests, but https://bugzilla.mozilla.org/show_bug.cgi?id=1406407#c6 shows that is not always the case, particularly for e10s. At issue is that the test harness updates mozinfo with e10s (and some other) info. But I think e10s intention is available in mozharness. https://dxr.mozilla.org/mozilla-central/rev/66f9b72b87297adf712b14be58df13c2333bb3a9/testing/mochitest/runtests.py#2483-2486
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=278ac14e6a13b7dfaafccb41c89f1c87d1766e56&filter-tier=1&filter-tier=2&filter-tier=3
Attachment #8923892 -
Flags: review?(jmaher)
|
||
Updated•7 years ago
|
Attachment #8923892 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0382668563a5 Update e10s mozinfo properties for test-verification; r=jmaher
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0382668563a5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•