Closed
Bug 1413013
Opened 9 years ago
Closed 9 years ago
nsITransactionList looks unused
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
15.19 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
From the code coverage report, it looks like nsTransactionList.cpp is never executed during tests.
From a quick inspection, it looks like dead code to me.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8923584 -
Flags: review?(m_kato)
|
||
Updated•9 years ago
|
Attachment #8923584 -
Flags: review?(m_kato) → review?(masayuki)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8923584 [details] [diff] [review]
Patch
getUndoList() and getRedoList() are still used by SeaMonkey. However, looks like that they are used only by their QA extensions:
https://searchfox.org/comm-central/source/suite/extensions/debugQA/content/debugQAEditorOverlay.js#391
https://searchfox.org/comm-central/source/suite/extensions/debugQA/content/debugQAEditorOverlay.js#369
So, perhaps, it's no problem to remove them from m-c.
Attachment #8923584 -
Flags: review?(masayuki) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96371614d917
Remove unused nsITransactionList. r=masayuki
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
Assignee | |
Updated•8 years ago
|
Blocks: deadcode-codecoverage
|
|
||
Updated•6 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•