1413079 - Windows opt SM-tc(p) jobs are going to permafail when Gecko 58 merges to Beta on 2017-11-02

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing SM job on Thursday's merge day.

Confirmed via bisection on Try that this is fallout from the VS2017 update :(. Only affects Windows opt builds (both Windows debug SM jobs are green).

The first patch below *should* suffice for reproducing locally, but the second one might also be needed.
https://hg.mozilla.org/try/rev/fc9912e88d8165a14a766f8012bd37565179d280
https://hg.mozilla.org/try/rev/6a5bec55044acecb9800c79eeb47447bf4b6a2fa

https://treeherder.mozilla.org/logviewer.html#?job_id=140926417&repo=try

TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\asm.js\testBullet.js | Unknown (code -2147483645, args "--ion-eager --ion-offthread-compile=off") [0.4 s]

And a lot more like it...

Comment 1

[(Away)]

Attachment: Fix variable lifetime

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8923972 [details] [diff] [review]
Fix variable lifetime

Review of attachment 8923972 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ec11e99791
Fix variable lifetime issue exposed by VS2017. r=arai CLOSED TREE

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8923972 [details] [diff] [review]
Fix variable lifetime

Looks good on Try too. Once again, you never fail to disappoint, David :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Once again, you never fail to disappoint, David :)

Hah, that came out exactly opposite of what I intended to say :P. Thanks for all the great work you do on an ongoing basis :)

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/90ec11e99791