Intermittent toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {

RESOLVED FIXED in Firefox 58

Status

defect
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: intermittent-bug-filer, Assigned: ntim)

Tracking

({intermittent-failure})

unspecified
mozilla59
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox58 fixed, firefox59 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(1 attachment)

Whiteboard: [stockwell unknown]
This has failed 33 times in the last 7 days. It occured on Linux x64 and Linux, affecting debug and asan build types.
Failing tests: debug-mochitest-browser-chrome-e10 and opt-mochitest-browser-chrome-e10.

Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=154459392&lineNumber=4332
Part of that log:
Testing getCurrent() with initial unthemed window
4282
[task 2018-01-05T22:43:37.883Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {} - Expected: 0, Actual: 0 - 
4283
[task 2018-01-05T22:43:37.885Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {} - Expected: 0, Actual: 0 - 
4284
[task 2018-01-05T22:43:37.886Z] 22:43:37     INFO - Testing getCurrent() with after theme.update()
4285
[task 2018-01-05T22:43:37.888Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4286
[task 2018-01-05T22:43:37.890Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4287
[task 2018-01-05T22:43:37.892Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4288
[task 2018-01-05T22:43:37.894Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4289
[task 2018-01-05T22:43:37.897Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4290
[task 2018-01-05T22:43:37.899Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4291
[task 2018-01-05T22:43:37.901Z] 22:43:37     INFO - Testing getCurrent() with after theme.update(windowId)
4292
[task 2018-01-05T22:43:37.903Z] 22:43:37     INFO - Buffered messages logged at 22:43:36
4293
[task 2018-01-05T22:43:37.904Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4294
[task 2018-01-05T22:43:37.907Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4295
[task 2018-01-05T22:43:37.908Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4296
[task 2018-01-05T22:43:37.911Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4297
[task 2018-01-05T22:43:37.913Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4298
[task 2018-01-05T22:43:37.915Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4299
[task 2018-01-05T22:43:37.917Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4300
[task 2018-01-05T22:43:37.919Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4301
[task 2018-01-05T22:43:37.921Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4302
[task 2018-01-05T22:43:37.923Z] 22:43:37     INFO - Testing getCurrent() after window focus change
4303
[task 2018-01-05T22:43:37.925Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4304
[task 2018-01-05T22:43:37.927Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4305
[task 2018-01-05T22:43:37.929Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4306
[task 2018-01-05T22:43:37.931Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4307
[task 2018-01-05T22:43:37.933Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4308
[task 2018-01-05T22:43:37.936Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4309
[task 2018-01-05T22:43:37.937Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4310
[task 2018-01-05T22:43:37.940Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4311
[task 2018-01-05T22:43:37.942Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4312
[task 2018-01-05T22:43:37.944Z] 22:43:37     INFO - Testing getCurrent() after another window focus change
4313
[task 2018-01-05T22:43:37.946Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4314
[task 2018-01-05T22:43:37.949Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4315
[task 2018-01-05T22:43:37.951Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4316
[task 2018-01-05T22:43:37.952Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 header URL should be applied - 
4317
[task 2018-01-05T22:43:37.954Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 accent color should be applied - Expected: #a14040, Actual: #a14040 - 
4318
[task 2018-01-05T22:43:37.956Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 1 text color should be applied - Expected: #fac96e, Actual: #fac96e - 
4319
[task 2018-01-05T22:43:37.958Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4320
[task 2018-01-05T22:43:37.959Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4321
[task 2018-01-05T22:43:37.962Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4322
[task 2018-01-05T22:43:37.964Z] 22:43:37     INFO - Testing getCurrent() after theme.reset(windowId)
4323
[task 2018-01-05T22:43:37.966Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4324
[task 2018-01-05T22:43:37.968Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4325
[task 2018-01-05T22:43:37.970Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4326
[task 2018-01-05T22:43:37.972Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {} - Expected: 0, Actual: 0 - 
4327
[task 2018-01-05T22:43:37.974Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 header URL should be applied - 
4328
[task 2018-01-05T22:43:37.976Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 accent color should be applied - Expected: #03fe03, Actual: #03fe03 - 
4329
[task 2018-01-05T22:43:37.978Z] 22:43:37     INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | Theme 2 text color should be applied - Expected: #0ef325, Actual: #0ef325 - 
4330
[task 2018-01-05T22:43:37.980Z] 22:43:37     INFO - Testing getCurrent() after reset and window focus change
4331
[task 2018-01-05T22:43:37.982Z] 22:43:37     INFO - Buffered messages finished
4332
[task 2018-01-05T22:43:37.983Z] 22:43:37     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_dynamic_getCurrent.js | {
4333
[task 2018-01-05T22:43:37.984Z] 22:43:37     INFO -   "colors": {
4334
[task 2018-01-05T22:43:37.985Z] 22:43:37     INFO -     "accentcolor": "#03fe03",
4335
[task 2018-01-05T22:43:37.986Z] 22:43:37     INFO -     "background_tab_text": null,
4336
[task 2018-01-05T22:43:37.986Z] 22:43:37     INFO -     "bookmark_text": null,
4337
[task 2018-01-05T22:43:37.987Z] 22:43:37     INFO -     "frame": null,
4338
[task 2018-01-05T22:43:37.988Z] 22:43:37     INFO -     "tab_text": null,
4339
[task 2018-01-05T22:43:37.989Z] 22:43:37     INFO -     "textcolor": "#0ef325",
4340
[task 2018-01-05T22:43:37.989Z] 22:43:37     INFO -     "toolbar": null,
4341
[task 2018-01-05T22:43:37.991Z] 22:43:37     INFO -     "toolbar_bottom_separator": null,
4342
[task 2018-01-05T22:43:37.991Z] 22:43:37     INFO -     "toolbar_field": null,
4343
[task 2018-01-05T22:43:37.992Z] 22:43:37     INFO -     "toolbar_field_border": null,
4344
[task 2018-01-05T22:43:37.993Z] 22:43:37     INFO -     "toolbar_field_text": null,
4345
[task 2018-01-05T22:43:37.993Z] 22:43:37     INFO -     "toolbar_text": null,
4346
[task 2018-01-05T22:43:37.994Z] 22:43:37     INFO -     "toolbar_top_separator": null,
4347
[task 2018-01-05T22:43:37.995Z] 22:43:37     INFO -     "toolbar_vertical_separator": null
4348
[task 2018-01-05T22:43:37.996Z] 22:43:37     INFO -   },
4349
[task 2018-01-05T22:43:37.996Z] 22:43:37     INFO -   "icons": null,
4350
[task 2018-01-05T22:43:37.998Z] 22:43:37     INFO -   "images": {
4351
[task 2018-01-05T22:43:37.998Z] 22:43:37     INFO -     "additional_backgrounds": null,
4352
[task 2018-01-05T22:43:37.999Z] 22:43:37     INFO -     "headerURL": "moz-extension://2a6a7b0d-4273-4ecb-a2e8-d8817513edab/image2.png",
4353
[task 2018-01-05T22:43:38.000Z] 22:43:38     INFO -     "theme_frame": null
4354
[task 2018-01-05T22:43:38.001Z] 22:43:38     INFO -   },
4355
[task 2018-01-05T22:43:38.002Z] 22:43:38     INFO -   "properties": null
4356
[task 2018-01-05T22:43:38.002Z] 22:43:38     INFO - } - Expected: 0, Actual: 4 - 
4357
[task 2018-01-05T22:43:38.003Z] 22:43:38     INFO - Stack trace:
4358
[task 2018-01-05T22:43:38.004Z] 22:43:38     INFO -     testEmptyTheme@moz-extension://2a6a7b0d-4273-4ecb-a2e8-d8817513edab/%7B126d308f-704e-4866-8eb9-7171a00beb5f%7D.js:53:9
4359
[task 2018-01-05T22:43:38.005Z] 22:43:38     INFO -     background@moz-extension://2a6a7b0d-4273-4ecb-a2e8-d8817513edab/%7B126d308f-704e-4866-8eb9-7171a00beb5f%7D.js:93:7
4360
[task 2018-01-05T22:43:38.006Z] 22:43:38     INFO -     async*@moz-extension://2a6a7b0d-4273-4ecb-a2e8-d8817513edab/%7B126d308f-704e-4866-8eb9-7171a00beb5f%7D.js:1:17

:andym could you please take a look?
Flags: needinfo?(amckay)
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]
:ntim might know something about it.
Flags: needinfo?(amckay) → needinfo?(ntim.bugs)
I think this has something to do with the window focus change part.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(ntim.bugs)
Comment on attachment 8942352 [details]
Bug 1413089 - Fix intermittent browser_ext_themes_dynamic_getCurrent.js.

https://reviewboard.mozilla.org/r/212636/#review218906

Looks good. Did you verify with try?
Attachment #8942352 - Flags: review?(mixedpuppy) → review+
(In reply to Shane Caraveo (:mixedpuppy) from comment #18)
> Comment on attachment 8942352 [details]
> Bug 1413089 - Fix intermittent browser_ext_themes_dynamic_getCurrent.js.
> 
> https://reviewboard.mozilla.org/r/212636/#review218906
> 
> Looks good. Did you verify with try?

I was able to reproduce the intermittent on Janitor, I can confirm this patch fixes it.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b5c0f99c9a35
Fix intermittent browser_ext_themes_dynamic_getCurrent.js. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/b5c0f99c9a35
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
https://hg.mozilla.org/releases/mozilla-release/rev/987fba771fbf
Flags: in-testsuite+
Whiteboard: [stockwell disable-recommended] → [stockwell fixed]
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.