141326 - broken hyperlink in editkeywords.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[David Lawrence [:dkl]]

In editkeywords.cgi, when deleting a keyword it generates a link to 
sanitycheck.cgi to Rebuild the keyword cache. This link has an incorrect 
closing tag for the hyperlink and there fore bleeds over in the next line  
generated by PutTrailer.  
 
sub RebuildCacheWarning { 
 
    print "<BR><BR><B>You have deleted or modified a keyword. You must rebuild 
the keyword cache!<BR></B>"; 
    print "You can rebuild the cache using sanitycheck.cgi. On very large 
installations of Bugzilla,<BR>"; 
    print "This can take several minutes.<BR><BR><B><A 
HREF=sanitycheck.cgi?rebuildkeywordcache=1>Rebuild cache</HREF><BR></B>"; 
 
} 
 
The </HREF> should be </A> 
 
Generating and attaching patch.

Comment 1

[David Lawrence [:dkl]]

Attachment: Fix for broken hyperlink in editkeywords.cgi

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 81769 [details] [diff] [review]
Fix for broken hyperlink in editkeywords.cgi

Quote the URL while you are there, and 2xr=gerv :-)

Gerv

Comment 3

[David Lawrence [:dkl]]

Attachment: Fix broken hyperlink in editkeywords.cgi (v2)

Added quotes around URL.

Comment 4

[David Lawrence [:dkl]]

Attachment: Fix broken hyperlink in editkeywords.cgi (v2)

Added quotes around URL.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 81769 [details] [diff] [review]
Fix for broken hyperlink in editkeywords.cgi

Obsoleteing this patch in favor of one with quotes. Also obsoleteing accidental
duplicate v2 patch.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 81778 [details] [diff] [review]
Fix broken hyperlink in editkeywords.cgi (v2)

Quote the URL while you are there, and 2xr=gerv :-)

Gerv

Comment 7

[David Lawrence [:dkl]]

Checking in editkeywords.cgi;  
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi  
new revision: 1.9; previous revision: 1.8  
done