1413281 - Logging into Sync on sync page (about:accounts?...) works, but not reflected in Settings

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android 57.0b11 on Android 6.0.1 (Sony Xperia Z3)

1. Reset Firefox Beta (cleared data from Android > Apps > Firefox Beta > Storage)
2. Open Firefox Beta.
3. Go to Settings
4. Tap the first option to sign in to Sync.
5. Sign in with your existing account.
6. Confirm the sign in with the link from the email if necessary.
Actual result:
Tab left open after sign in says everything is fine.
Expected result:
Able to choose what to Sync.
7. Go to Settings.
Actual result:
First menu item is still about signing in, can't select what to Sync.
Expected result:
First menu item has the email address of the account and let's one choose the syncable items (works in Firefox for Android Nightly 58.0a1 20171030).

Reproducable: 5/5

Comment 1

[Ryan Kelly [:rfkelly]]

Thanks for the report!

> 6. Confirm the sign in with the link from the email if necessary.
> Actual result:
> Tab left open after sign in says everything is fine.
> Expected result:
> Able to choose what to Sync.

The "choose what to sync" settings are per-account, not per-device.  Since you're signing in with an existing account, sync will use the sync data choices already stored under that account.

> 7. Go to Settings.
> Actual result:
> First menu item is still about signing in, can't select what to Sync.

I wasn't able to reproduce this on a fresh install of Beta, but I'm going to try some more using the reset procedure you describe above.

Comment 2

[Ryan Kelly [:rfkelly]]

> 1. Reset Firefox Beta (cleared data from Android > Apps > Firefox Beta > Storage)

This doesn't cause me to be signed out of sync; disconnecting from sync and resetting the account also didn't repro the bug for me.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Tried it with the account remove from Android's account list. Android's Sync is set to disabled. With remote debugging enabled, the XHRs during sign in process all end up as 200s. No username/password gets shown in Fennec's password manager.

Comment 4

[:Grisha Kruglov]

It seems that your account got into a strange state, and I'm not sure why. Perhaps android logs (output of |adb logcat|) from your device as you're going through the STR steps will shed some light. If you can still repro the issue, do you mind attaching them?

> 1. Reset Firefox Beta (cleared data from Android > Apps > Firefox Beta > Storage)

Note that this will not remove your account locally. If you were logged in, and cleared application data, you'll remain logged in.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: adb logcat of lines containing 'gecko'

This are the lines of the logcat which contain the word 'gecko'. Let me know if you need the full log. While logcat got recorded, I tapped Firefox on the home screen, opened the menu > Settings > top menu item for sync and signed in in the tab. This issue still reproduces with 58.0 but not with 60.0a1 20160123. There is currently no 59 beta.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #5)
> Created attachment 8944856 [details]
> adb logcat of lines containing 'gecko'
> 
> This are the lines of the logcat which contain the word 'gecko'. Let me know
> if you need the full log. While logcat got recorded, I tapped Firefox on the
> home screen, opened the menu > Settings > top menu item for sync and signed
> in in the tab. This issue still reproduces with 58.0 but not with 60.0a1
> 20160123. There is currently no 59 beta.

Lines containing Sync and FxA would help too.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: gecko-sync-fxa.txt

Comment 8

[:Grisha Kruglov]

Thanks! Going to look into this a bit closer, but at first glance:

Here's the Android's account manager failing to insert a supposedly new account into its internal database:
> Line 8216: 01-23 21:23:13.545  1873  3949 W AccountManagerService: insertAccountIntoDatabase: Account {name=***@***.de, type=org.mozilla.firefox_fxaccount}, skipping since the account already exists
> Line 8220: 01-23 21:23:13.548 27969  6680 W GeckoLogger: firefox :: AccountPickler :: Failed to add Android Account; aborting.
> Line 8221: 01-23 21:23:13.564  1873  3401 W AccountManagerService: insertAccountIntoDatabase: Account {name=***@***.de, type=org.mozilla.firefox_fxaccount}, skipping since the account already exists
> Line 8222: 01-23 21:23:13.564 27969  7277 W GeckoLogger: firefox :: AccountPickler :: Failed to add Android Account; aborting.

The above indicates that at some point we're failing to correctly query presence of the account in the AccountManager.

This also doesn't look quite right to me (so many repeated messages!):
> Line 7566: 01-23 21:22:48.620 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:loaded
> Line 7566: 01-23 21:22:48.620 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:loaded
> Line 7566: 01-23 21:22:48.620 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:loaded
> Line 7566: 01-23 21:22:48.620 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:loaded
> Line 7567: 01-23 21:22:48.665 27969 28579 D GeckoFxAccounts: Got LOADED message!
> Line 7567: 01-23 21:22:48.665 27969 28579 D GeckoFxAccounts: Got LOADED message!
> ...
> Line 7855: 01-23 21:23:02.312 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:can_link_account
> Line 7855: 01-23 21:23:02.312 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:can_link_account
> Line 7855: 01-23 21:23:02.312 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:can_link_account
> Line 7855: 01-23 21:23:02.312 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:can_link_account
> Line 7856: 01-23 21:23:02.315 27969 28579 D GeckoFxAccounts: Not warning about creating a new Android Account: no previously linked email address.
> Line 7856: 01-23 21:23:02.315 27969 28579 D GeckoFxAccounts: Not warning about creating a new Android Account: no previously linked email address.
> Line 7857: 01-23 21:23:02.315 27969 28579 D GeckoFxAccounts: Sending response to command: fxaccounts:can_link_account
> Line 7857: 01-23 21:23:02.315 27969 28579 D GeckoFxAccounts: Sending response to command: fxaccounts:can_link_account
> Line 7857: 01-23 21:23:02.315 27969 28579 D GeckoFxAccounts: Sending response to command: fxaccounts:can_link_account
> ...
> Line 7895: 01-23 21:23:06.719 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:login
> Line 7895: 01-23 21:23:06.719 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:login
> Line 7895: 01-23 21:23:06.719 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:login
> Line 7895: 01-23 21:23:06.719 27969 28579 D GeckoFxAccounts: FxAccountsWebChannel message received, command: fxaccounts:login
> ...
> Line 7937: 01-23 21:23:07.397 27969 28579 I GeckoFxAccounts: Created or updated Firefox Account.
> Line 7937: 01-23 21:23:07.397 27969 28579 I GeckoFxAccounts: Created or updated Firefox Account.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry for the trouble, the root cause was that the XPrivacy system/app was blocking access to the accounts (but some reason allowed to created accounts). Switching that setting makes the workflow work.

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #9)
> Sorry for the trouble, the root cause was that the XPrivacy system/app was
> blocking access to the accounts (but some reason allowed to created
> accounts). Switching that setting makes the workflow work.

Fascinating.  Thanks for letting us know -- another thing to query for in unusual configurations.