Closed
Bug 1413488
Opened 7 years ago
Closed 7 years ago
[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data"
Categories
(Toolkit :: Form Autofill, enhancement, P5)
Toolkit
Form Autofill
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: lchang, Assigned: lchang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [form autofill])
Attachments
(1 file)
Since "data" shouldn't be accessed publicly, we should follow the convention of private variables to name it "_data".
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → lchang
|
||
Updated•7 years ago
|
Component: Form Manager → Form Autofill
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928848 [details] Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data". https://reviewboard.mozilla.org/r/200138/#review205822 LGTM!
Attachment #8928848 -
Flags: review?(selee) → review+
| Comment hidden (mozreview-request) |
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/130f10cfd1b5 [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data". r=seanlee
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/130f10cfd1b5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•