Closed Bug 1413488 Opened 3 years ago Closed 3 years ago

[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data"

Categories

(Toolkit :: Form Autofill, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill])

Attachments

(1 file)

Since "data" shouldn't be accessed publicly, we should follow the convention of private variables to name it "_data".
Assignee: nobody → lchang
Component: Form Manager → Form Autofill
Status: NEW → ASSIGNED
Comment on attachment 8928848 [details]
Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data".

https://reviewboard.mozilla.org/r/200138/#review205822

LGTM!
Attachment #8928848 - Flags: review?(selee) → review+
Thanks.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/130f10cfd1b5
[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data". r=seanlee
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/130f10cfd1b5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.