[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data"

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lchang, Assigned: lchang)

Tracking

(Blocks 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [form autofill])

Attachments

(1 attachment)

Since "data" shouldn't be accessed publicly, we should follow the convention of private variables to name it "_data".
Assignee: nobody → lchang
Component: Form Manager → Form Autofill
Status: NEW → ASSIGNED
Comment on attachment 8928848 [details]
Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data".

https://reviewboard.mozilla.org/r/200138/#review205822

LGTM!
Attachment #8928848 - Flags: review?(selee) → review+
Thanks.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/130f10cfd1b5
[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data". r=seanlee
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/130f10cfd1b5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.