1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data"

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P5)

Description

[Luke Chang [:lchang] (inactive)]

Since "data" shouldn't be accessed publicly, we should follow the convention of private variables to name it "_data".

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data".

Review commit: https://reviewboard.mozilla.org/r/200138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200138/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8928848 [details]
Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data".

https://reviewboard.mozilla.org/r/200138/#review205822

LGTM!

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8928848 [details]
Bug 1413488 - [Form Autofill] Rename the "data" property of "AutofillRecords" to "_data".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200138/diff/1-2/

Comment 4

[Luke Chang [:lchang] (inactive)]

Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/130f10cfd1b5
[Form Autofill] Rename the "data" property of "AutofillRecords" to "_data". r=seanlee

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/130f10cfd1b5