Closed Bug 1413713 Opened 8 years ago Closed 8 years ago

"Start Browsing" button on the Onboarding screen should respect Safe Area Insets on the iPhone X

Categories

(Firefox for iOS :: Browser, defect, P2)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 10.3 ---
fxios-v11.0 --- verified

People

(Reporter: farhan, Unassigned, Mentored)

References

Details

(Whiteboard: [good-first-bug][iPhoneX])

The "Start Browsing" button is too low. Should appear outside of the safe area.
Blocks: 1413720
tracking-fxios: ? → 10.1
Priority: -- → P2
Whiteboard: [good-first-bug] → [good-first-bug][iPhoneX]
I just sent a PR for this bug. Could you review please? It's my first bug. https://github.com/mozilla-mobile/firefox-ios/pull/3459
Thanks Jhonatas! and welcome to the Firefox iOS project. I'f you'd like to pick up some of the other iPhone X bugs that would be greatly appreciated. If you have any questions feel free to NeedInfo me :)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verifying as fix on master eedc08e7349c8825.
status-fxios-v11.0: --- → verified
You need to log in before you can comment on or make changes to this bug.