1413941 - Fix broken netmonitor launchpad regression from bug 1360457

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

Netmonitor launchpad is broken since we don't pay attention on bug 1360457. connector should be passed into StatusBar.

The font size of empty request list should apply 1.2rem as well. Follow-up patch will be submitted soon.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457

Review commit: https://reviewboard.mozilla.org/r/195806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195806/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8924560 [details]
Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457

https://reviewboard.mozilla.org/r/195806/#review201004

Looks good to me.
R+ assuming try is green

Thanks Ricky!
Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e16e1fb28941
Fix broken netmonitor launchpad regression from bug 1360457 r=Honza

Comment 4

[Andreea Pavel [:apavel]]

Backed out for backout bug https://bugzilla.mozilla.org/show_bug.cgi?id=1407561 

Link to backout: https://hg.mozilla.org/integration/autoland/rev/2ec0c37e6fed0d7ed02dcb8eba80eae97143ee83

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff1cd0bcf084
Backed out changeset e16e1fb28941 for backout of bug 1407561 r=backout on a CLOSED TREE

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8924560 [details]
Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195806/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180cd6b0a974
Fix broken netmonitor launchpad regression from bug 1360457 r=Honza

Comment 9

[tera_1225]

Hey guys.
Sorry about this, this is my mistake, in fixing Bug 1360457 I introduced this. Thanks for the fix Ricky. Once again sorry for messing up here, I did have it functional (I think) until I rebased and got tangled up in the merge :/

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/180cd6b0a974