Declaration of USEC_PER_SEC conflicts with #define on MacOS

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

The changes in bug 1410132 trigger a compile error in dom/media/mediasource/ContainerParser.cpp on MacOS due to causing mach/clock_types.h to be included, which #defines USEC_PER_SEC.

https://treeherder.mozilla.org/logviewer.html#?job_id=141701516&repo=mozilla-inbound&lineNumber=15466

Fortunately this constant doesn't seem to be used anywhere so I think we can just remove it.
Attachment #8924623 - Flags: review?(jyavenard)
Comment on attachment 8924623 [details] [diff] [review]
remove-conflicting-const

Review of attachment 8924623 [details] [diff] [review]:
-----------------------------------------------------------------

Please change the commit title to:
Remove unused USEC_PER_SEC constant
And in the details explain on the why (conflict and so forth) 


Thank you.
Attachment #8924623 - Flags: review?(jyavenard) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79def5ebdec2
Remove unused USEC_PER_SEC constant r=jya
https://hg.mozilla.org/mozilla-central/rev/79def5ebdec2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.