1414010 - Re-enable FxA Leanplum A/B push test

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement)

Description

[Vijay Budhram]

FxA recently landed code to perform A/B testing for push permissions. However, this feature had to be disabled before app was published to App Store because of conflicting configurations. Spoke with st3fan and we mapped out what the correct configuration is needed for this to be enabled in production.

  * Expose a `isEnabled()` function that looks into the SDK and checks that Leanplum is enabled for a given loaded local, else don't perform A/B test. We can not rely on the SDK feature flag to say that user would/wouldn't get test.
  * Add a Leanplum remote configuration variable that can turn off this feature. Only users with this configuration set to true will be enrolled in A/B test.

Once this had been added, we should be able to safely sync the new message templates and variables and turn on the experiment for users.

Comment 1

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3471

Updated this based on the comments above. r?

Comment 2

[Vijay Budhram]

Comment on attachment 8929440 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3471

Resolved conflicts and updated to use new Leanplum funcs.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on master, uplifted to v10.x