Closed
Bug 1414048
Opened 7 years ago
Closed 7 years ago
Make new Bng (Build, non-Gradle) build run the full Android test suite
Categories
(Firefox for Android Graveyard :: Testing, enhancement)
Firefox for Android Graveyard
Testing
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: nalexander, Assigned: gbrown)
References
Details
Attachments
(1 file)
1.57 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
It looks like Bug 1405396 is going to stick. That ticket swapped the B and Bg builds, making B build --with-gradle and turning the Bg into Bng --without-gradle.
We want to ensure that Bng doesn't rot post-Gradle until we're ready to remove it entirely, and that means we should run the full test suite against these builds.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
Like so?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6041f4a9a6208569471c9308761d75fe823918b
Do we want Bng *debug* builds/tests also?
Flags: needinfo?(nalexander)
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #1)
> Like so?
>
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d6041f4a9a6208569471c9308761d75fe823918b
>
> Do we want Bng *debug* builds/tests also?
Yeah! I'm not certain, but I doubt we would see valuable information from mismatched Java (--without-gradle) and Debug C++ code. It's possible, but unlikely.
snorp, is there significant value building the old --without-gradle configuration and debug C++ and running tests against it?
Flags: needinfo?(nalexander) → needinfo?(snorp)
Yeah I agree, not useful.
Flags: needinfo?(snorp)
![]() |
Assignee | |
Comment 4•7 years ago
|
||
Assignee: nobody → gbrown
Attachment #8929577 -
Flags: review?(nalexander)
Reporter | ||
Comment 5•7 years ago
|
||
Comment on attachment 8929577 [details] [diff] [review]
run all tests, except geckoview, on Bng
Review of attachment 8929577 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm. Thanks, gbrown!
Attachment #8929577 -
Flags: review?(nalexander) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07cd8a123061
Run full Android test suite for Android Bng; r=nalexander
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•