Closed Bug 1414051 Opened 2 years ago Closed Last year

Complete an end-to-end test of the TheatHit API

Categories

(Toolkit :: Safe Browsing, enhancement, P1)

Product:
Toolkit
Component:
Safe Browsing
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox57 --- unaffected
firefox62 --- fixed

People

(Reporter: francois, Assigned: francois)

References

(Blocks 1 open bug)

Details

(Whiteboard: pwphish-threathit)

Attachments

(1 file)

Bug 1414051 - Move ThreatHit protobuf details to the body.
59 bytes, text/x-review-board-request
gcp
: review+
Details 
The initial support for the ThreatHit API has landed (pref'ed off) in bug 1331138.

We need to conduct an end-to-end test with Google to make sure it works as expected.
(In reply to François Marier [:francois] from comment #0)
> The initial support for the ThreatHit API has landed (pref'ed off) in bug 1331138.
> 
> We need to conduct an end-to-end test with Google to make sure it works as expected.

Is this a requirement for Quantum? If not please update the status flags accordingly.
Flags: needinfo?(francois)
I should have linked to bug 1351147 directly.

This landed in 58, so it's not relevant for 57.
status-firefox57: --- → unaffected
Flags: needinfo?(francois)
This is no longer needed since we will be switching to a different API/endpoint in bug 1442780.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Just going to reopen this temporarily in order to land a few fixes.

It's not clear when the work on the new API will actually happen. In the meantime, we may as well land my small cleanup patch.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment on attachment 8983149 [details]
Bug 1414051 - Move ThreatHit protobuf details to the body.

https://reviewboard.mozilla.org/r/248984/#review255846
Attachment #8983149 - Flags: review?(gpascutto) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/486bd3917dee
Move ThreatHit protobuf details to the body. r=gcp
https://hg.mozilla.org/mozilla-central/rev/486bd3917dee
Status: REOPENED → RESOLVED
Closed: 2 years ago → Last year
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.