1414053 - DevTools.jsm should use a custom callback instead of selectors to get the cropping region

Status: RESOLVED FIXED

(Testing :: mozscreenshots, defect)

Description

[Robin Miller]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170926100259

Steps to reproduce:

Attempt to run any test involving DevTools.jsm on the new integration bug #1403686.


Actual results:

TestRunner.jsm fails with null element errors when it tries to the use the selectors, because the selectors can't cross the boundary into the anonymous devtools element.


Expected results:

It should use the new, more flexible selector API to use a custom callback to cross into the devtools element and run the query there.

Comment 1

[Robin Miller]

Attachment: Bug 1414053 - Adds the boundary crossing callback to DevTools.jsm.

Also, once this lands, it should clean up some of the failing tests on Bugs #1403686 and #1412357.

Review commit: https://reviewboard.mozilla.org/r/195934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195934/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8924714 [details]
Bug 1414053 - Adds the boundary crossing callback to DevTools.jsm.

https://reviewboard.mozilla.org/r/195934/#review201422

Thanks grenewode! Looks good - just one suggestion; see below.

::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/DevTools.jsm:32
(Diff revision 1)
> +        function() {
> +          return gDevTools.getToolbox(getTargetForSelectedTab()).win.document.querySelector("#toolbox-container");
> +        }

Could we define this function once as a property on `DevTools` and refer to it each time you're using it here to DRY this code up?

Comment 3

[Robin Miller]

Comment on attachment 8924714 [details]
Bug 1414053 - Adds the boundary crossing callback to DevTools.jsm.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195934/diff/1-2/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8924714 [details]
Bug 1414053 - Adds the boundary crossing callback to DevTools.jsm.

https://reviewboard.mozilla.org/r/195934/#review201910

Looks great, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13763ec91000
Adds the boundary crossing callback to DevTools.jsm.  r=mconley

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed!

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/13763ec91000